Fix the only non-C90 comment to be C90 compatible.#566
Fix the only non-C90 comment to be C90 compatible.#566serhiy-storchaka merged 1 commit intopython:masterfrom ndparker:C99-comment
Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA. This is necessary for legal reasons before we can look at your contribution. Please follow these steps to help rectify the issue:
Thanks again to your contribution and we look forward to looking at it! |
|
@ndparker, thanks for your PR! By analyzing the history of the files in this pull request, we identified @benjaminp, @tim-one, @Yhg1s, @mdickinson and @mhammond to be potential reviewers. |
|
Could you please backport this change to 3.6 @ndparker? |
|
FWIW, I've signed the CLA now :-) @serhiy-storchaka Thanks for merging. Should I open another PR for python 3.6 or how is it supposed to be done? |
|
Thanks @ndparker. Signing the CLA for such trivial change is not needed, but i hope this is not your last contribution. Just open another PR for Python 3.6. |
Including pyport.h into a module compiled with a C89/90 compiler gives the error:
C++ style comments are not allowed in ISO C90.
It would be nice to be included into the next python 3.6 version as well.