Skip to content

[3.7] Fix typo in Include/objimpl.h, the word "has" was missing (GH-5568)#5569

Merged
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-517da1e-3.7
Feb 12, 2018
Merged

[3.7] Fix typo in Include/objimpl.h, the word "has" was missing (GH-5568)#5569
miss-islington merged 1 commit into
python:3.7from
miss-islington:backport-517da1e-3.7

Conversation

@miss-islington

Copy link
Copy Markdown
Contributor

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey forestbiiird@gmail.com

)

It now reads: ...be aware that Python has no control over...
(cherry picked from commit 517da1e)

Co-authored-by: Alexey <forestbiiird@gmail.com>
@the-knights-who-say-ni

Copy link
Copy Markdown

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately our records indicate you have not signed the CLA. For legal reasons we need you to sign this before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@miss-islington

Copy link
Copy Markdown
Contributor Author

@WouldYouKindly and @Mariatta: Backport status check is done, and it's a success ✅ .

1 similar comment
@miss-islington

Copy link
Copy Markdown
Contributor Author

@WouldYouKindly and @Mariatta: Backport status check is done, and it's a success ✅ .

@Mariatta Mariatta left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trigger miss-islington

@bedevere-bot

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@miss-islington

Copy link
Copy Markdown
Contributor Author

@WouldYouKindly and @Mariatta: Backport status check is done, and it's a failure ❌ .

@miss-islington

Copy link
Copy Markdown
Contributor Author

@WouldYouKindly and @Mariatta: Backport status check is done, and it's a success ✅ .

@miss-islington miss-islington merged commit 972edd9 into python:3.7 Feb 12, 2018
@miss-islington

Copy link
Copy Markdown
Contributor Author

Thanks!

@miss-islington miss-islington deleted the backport-517da1e-3.7 branch February 12, 2018 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants