Skip to content

gh-76961: Fix the PEP3118 format string for ctypes.Structure #5561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mdickinson merged 10 commits into from
Feb 5, 2023
Merged

gh-76961: Fix the PEP3118 format string for ctypes.Structure #5561

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ac4e5bb
bpo-32780: Fix the PEP3118 format string for ctypes.Structure
eric-wieser Feb 6, 2018
e6021e1
Merge branch 'master' into ctypes-padding
eric-wieser Nov 28, 2019
97e9d95
Merge remote-tracking branch 'upstream/main' into ctypes-padding
eric-wieser Jul 7, 2022
6bf5a25
remove unused variable, extend documentation
eric-wieser Jul 8, 2022
3b7f14f
comment
eric-wieser Jul 8, 2022
27b1601
fix incorrect name and documentation
eric-wieser Aug 15, 2022
e300e16
remove the heap allocation as requested
eric-wieser Aug 15, 2022
7e8b4f9
Merge branch 'main' into ctypes-padding
eric-wieser Dec 23, 2022
4de7a8a
Update Misc/NEWS.d/next/Core and Builtins/2018-02-05-21-54-46.bpo-327…
eric-wieser Feb 5, 2023
26311ae
Apply suggestions from code review
eric-wieser Feb 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix incorrect name and documentation
  • Loading branch information
@eric-wieser
eric-wieser committed Aug 15, 2022
commit 27b1601038a87f76f32bffbabf1877ff9345a520
6 changes: 3 additions & 3 deletions Modules/_ctypes/stgdict.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,10 +341,10 @@ MakeAnonFields(PyObject *type)
}

/*
Compute ceil(log10(x)), for the purpose of determining string lengths.
Compute `floor(log10(x)) + 1`, for the purpose of determining string lengths.
*/
static Py_ssize_t
clog10(Py_ssize_t n)
num_digits_of(Py_ssize_t n)
{
Py_ssize_t log_n = 0;
while (n > 0) {
Expand All @@ -371,7 +371,7 @@ _ctypes_alloc_format_padding(const char *prefix, Py_ssize_t padding)
}

/* decimal characters + x + null */
buf = PyMem_Malloc(clog10(padding) + 2);
buf = PyMem_Malloc(num_digits_of(padding) + 2);
if (buf == NULL) {
PyErr_NoMemory();
return NULL;
Expand Down