Skip to content

Fix typo in whatsnew/3.7.rst#5551

Merged
Mariatta merged 1 commit into
python:masterfrom
dagheyman:master
Feb 5, 2018
Merged

Fix typo in whatsnew/3.7.rst#5551
Mariatta merged 1 commit into
python:masterfrom
dagheyman:master

Conversation

@dagheyman
Copy link
Copy Markdown

@dagheyman dagheyman commented Feb 5, 2018

now longer -> no longer

@dagheyman
Fix typo in whatsnew/3.7.rst
7d9503a 
now longer -> no longer
@the-knights-who-say-ni
Copy link
Copy Markdown

the-knights-who-say-ni commented Feb 5, 2018

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA).

Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

Thanks again to your contribution and we look forward to looking at it!

@Mariatta Mariatta merged commit c309bcf into python:master Feb 5, 2018
@miss-islington
Copy link
Copy Markdown
Contributor

miss-islington commented Feb 5, 2018

Thanks @dagheyman for the PR, and @Mariatta for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 5, 2018
@dagheyman @miss-islington
Fix typo in whatsnew/3.7.rst (pythonGH-5551)
b2f8677 
now longer -> no longer
(cherry picked from commit c309bcf)

Co-authored-by: Dag Heyman <dag@yubico.com>
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Feb 5, 2018

GH-5553 is a backport of this pull request to the 3.7 branch.

@Mariatta
Copy link
Copy Markdown
Member

Mariatta commented Feb 5, 2018

Thanks @dagheyman and congrats on your first contribution to CPython 🌮
This is straightforward change, so CLA is not needed.
However, please do sign it for your future contributions!

@matrixise
Copy link
Copy Markdown
Member

matrixise commented Feb 5, 2018

@dagheyman yes, please, just sign the CLA, because without that, @the-knights-who-say-ni will check your status, and we won't review your contributions without the CLA :/

Thank you

Mariatta pushed a commit that referenced this pull request Feb 7, 2018
@miss-islington @dagheyman @Mariatta
Fix typo in whatsnew/3.7.rst (GH-5551) (GH-5553)
a702f6b 
now longer -> no longer
(cherry picked from commit c309bcf)

Co-authored-by: Dag Heyman <dag@yubico.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Mariatta Mariatta Mariatta approved these changes

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dagheyman @the-knights-who-say-ni @miss-islington @bedevere-bot @Mariatta @matrixise