Skip to content

bpo-32765: Update configdialog docstrings to reflect new layout#5529

Merged
terryjreedy merged 3 commits into
python:masterfrom
csabella:configdialog
Feb 4, 2018
Merged

bpo-32765: Update configdialog docstrings to reflect new layout#5529
terryjreedy merged 3 commits into
python:masterfrom
csabella:configdialog

Conversation

@csabella

@csabella csabella commented Feb 4, 2018 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

@csabella csabella requested a review from terryjreedy as a code owner February 4, 2018 16:57
terryjreedy
terryjreedy requested changes Feb 4, 2018
View reviewed changes

@terryjreedy terryjreedy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Additions look exactly right. Please add blurb with condensed title and text "Add new widgets to widget list." and I will merge.

In the future, please include first draft blurb, even with blank or dummy text, with original PR (unless not needed). It will be total less work.

@bedevere-bot

bedevere-bot commented Feb 4, 2018

Copy link
Copy Markdown

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@csabella

csabella commented Feb 4, 2018

Copy link
Copy Markdown
Contributor Author

I have made the requested changes; please review again. I'll be sure to include the blurb with my initial commit.

@bedevere-bot

bedevere-bot commented Feb 4, 2018

Copy link
Copy Markdown

Thanks for making the requested changes!

@terryjreedy: please review the changes made to this pull request.

@terryjreedy terryjreedy merged commit 845d864 into python:master Feb 4, 2018
@miss-islington

miss-islington commented Feb 4, 2018

Copy link
Copy Markdown
Contributor

Thanks @csabella for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.6, 3.7.
🐍🍒⛏🤖

@bedevere-bot

bedevere-bot commented Feb 4, 2018

Copy link
Copy Markdown

GH-5537 is a backport of this pull request to the 3.7 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2018
@csabella @miss-islington
bpo-32765: Update configdialog General tab create page docstring (pyt…
a7d4b3d 
…honGH-5529)

Add new entries to the widget list.
(cherry picked from commit 845d864)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Feb 4, 2018
@csabella @miss-islington
bpo-32765: Update configdialog General tab create page docstring (pyt…
0c19316 
…honGH-5529)

Add new entries to the widget list.
(cherry picked from commit 845d864)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 4, 2018

Copy link
Copy Markdown

GH-5538 is a backport of this pull request to the 3.6 branch.

terryjreedy pushed a commit that referenced this pull request Feb 4, 2018
@miss-islington @csabella @terryjreedy
bpo-32765: Update configdialog General tab create page docstring (GH-…
5b933aa 
…5529) (GH-5537)

Add new entries to the widget list.
(cherry picked from commit 845d864)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
terryjreedy pushed a commit that referenced this pull request Feb 5, 2018
@miss-islington @csabella @terryjreedy
bpo-32765: Update configdialog General tab create page docstring (GH-…
1c2b138 
…5529) (GH-5538)

Add new entries to the widget list.
(cherry picked from commit 845d864)

Co-authored-by: Cheryl Sabella <cheryl.sabella@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@terryjreedy terryjreedy terryjreedy approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@csabella @bedevere-bot @miss-islington @terryjreedy @the-knights-who-say-ni