Skip to content

bpo-32604: Fix memory leaks in the new _xxsubinterpreters module. #5507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericsnowcurrently merged 19 commits into from
Feb 3, 2018
+607 −276
Merged

bpo-32604: Fix memory leaks in the new _xxsubinterpreters module. #5507

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e12d641
DECREF cls in _PyCrossInterpreterData_Lookup().
ericsnowcurrently Jan 30, 2018
ce72eef
DECREF the id in interp_list_all().
ericsnowcurrently Jan 30, 2018
27bbab7
Avoid raising RunFailedError.
ericsnowcurrently Jan 31, 2018
c744873
DECREF id in _coerce_id().
ericsnowcurrently Jan 31, 2018
e982d87
DECREF the original error message.
ericsnowcurrently Jan 31, 2018
aac9485
Do not explicitly check against INT64_MAX.
ericsnowcurrently Jan 31, 2018
35f6046
Free cids when done.
ericsnowcurrently Jan 31, 2018
38d924e
DECREF other in channelid_richcompare().
ericsnowcurrently Jan 31, 2018
4321ecf
Add items to non-empty channels.
ericsnowcurrently Feb 2, 2018
e5a3515
Add struct _sharedns and isolate related memory ops.
ericsnowcurrently Feb 2, 2018
0c0fa3d
Clean up memory ops for _sharedexception.
ericsnowcurrently Feb 2, 2018
f0d4430
Clean up _PyChannelState memory ops.
ericsnowcurrently Feb 3, 2018
4802046
Add _channelref_free().
ericsnowcurrently Feb 3, 2018
ac7bad5
Move the RunFailedError definition down.
ericsnowcurrently Feb 3, 2018
0689a9c
Do not INCREF after PyErr_Fetch().
ericsnowcurrently Feb 3, 2018
9a91a28
DECREF the exception name.
ericsnowcurrently Feb 3, 2018
654e59a
Free the channel when we close it.
ericsnowcurrently Feb 3, 2018
8ca3c96
Free the data when we are done with it.
ericsnowcurrently Feb 3, 2018
702876b
DECREF the ID in channelid_hash().
ericsnowcurrently Feb 3, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Do not explicitly check against INT64_MAX.
  • Loading branch information
@ericsnowcurrently
ericsnowcurrently committed Feb 3, 2018
commit aac9485031de7b9c2ee78d13d4a3d9d1fa8e6ec6
6 changes: 3 additions & 3 deletions Lib/test/test__xxsubinterpreters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -763,12 +763,12 @@ def __int__(self):
self.assertEqual(int(cid), 10)

def test_bad_id(self):
ids = [-1, 2**64, "spam"]
for cid in ids:
for cid in [-1, 'spam']:
with self.subTest(cid):
with self.assertRaises(ValueError):
interpreters._channel_id(cid)

with self.assertRaises(OverflowError):
interpreters._channel_id(2**64)
with self.assertRaises(TypeError):
interpreters._channel_id(object())

Expand Down
15 changes: 6 additions & 9 deletions Modules/_xxsubinterpretersmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,23 +31,20 @@ _coerce_id(PyObject *id)
}
return -1;
}
long long cid = PyLong_AsLongLong(id);
int64_t cid = PyLong_AsLongLong(id);
Py_DECREF(id);
if (cid == -1 && PyErr_Occurred() != NULL) {
PyErr_SetString(PyExc_ValueError,
"'id' must be a non-negative int");
if (!PyErr_ExceptionMatches(PyExc_OverflowError)) {
PyErr_SetString(PyExc_ValueError,
"'id' must be a non-negative int");
}
return -1;
}
if (cid < 0) {
PyErr_SetString(PyExc_ValueError,
"'id' must be a non-negative int");
return -1;
}
if (cid > INT64_MAX) {
PyErr_SetString(PyExc_ValueError,
"'id' too large (must be 64-bit int)");
return -1;
}
return cid;
}

Expand Down Expand Up @@ -1231,7 +1228,7 @@ channelid_richcompare(PyObject *self, PyObject *other, int op)
if (othercid == -1 && PyErr_Occurred() != NULL) {
return NULL;
}
if (othercid < 0 || othercid > INT64_MAX) {
if (othercid < 0) {
equal = 0;
}
else {
Expand Down