bpo-32651 Recommend getpass.getuser()#5301
Merged
Merged
Conversation
berkerpeksag
approved these changes
Jan 24, 2018
Member
berkerpeksag
left a comment
There was a problem hiding this comment.
Since this is a small documentation improvement, a NEWS entry is not needed. If you still want to add it, I just left a comment :)
Do you plan to backport this to the 3.6 branch? I think it would be nice to get this into the 3.6 branch.
| @@ -0,0 +1,2 @@ | |||
| In the :func:`os.getlogin()` documentation, recommend | |||
| func:`getpass.getuser()`. | |||
Member
There was a problem hiding this comment.
Missing ':' here. And use of parenthesis is not needed.
Member
Author
|
@berkerpeksag Yeah, I guess that's true. I've added the tag and will remove the file. |
Member
Author
|
I do plan on back porting this too, so I've added that label. |
Contributor
|
Thanks @warsaw for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jan 24, 2018
* bpo-32651 - In the documentation for os.getlogin(), recommend getpass.getuser() (cherry picked from commit d499031)
|
GH-5304 is a backport of this pull request to the 3.6 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue32651