Skip to content

[3.6] bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (GH-5284)#5296

Merged
vstinner merged 1 commit into
python:3.6from
miss-islington:backport-e768c86-3.6
Jan 24, 2018
Merged

[3.6] bpo-32635: Fix a segfault when importing the crypt module with libxcrypt. (GH-5284)#5296
vstinner merged 1 commit into
python:3.6from
miss-islington:backport-e768c86-3.6

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Jan 24, 2018

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
(cherry picked from commit e768c86)

https://bugs.python.org/issue32635

…ypt. (pythonGH-5284)

glibc is deprecating libcrypt in favor of libxcrypt, however python assumes
that crypt.h will always be included. This change makes the header inclusion
explicit when libxcrypt is present on the system.
(cherry picked from commit e768c86)
Copy link
Copy Markdown
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@vstinner
Copy link
Copy Markdown
Member

@tiran agrees that a 2.7 backport is needed: "yes, go ahead"
https://bugs.python.org/issue32635#msg310575

@miss-islington
Copy link
Copy Markdown
Contributor Author

@stratakis and @vstinner: Backport status check is done, and it's a success ✅ .

@vstinner vstinner merged commit 8e230e1 into python:3.6 Jan 24, 2018
@miss-islington
Copy link
Copy Markdown
Contributor Author

Thanks, @vstinner!

@miss-islington miss-islington deleted the backport-e768c86-3.6 branch January 24, 2018 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants