[3.6] bpo-32502: Discard 64-bit (and other invalid) hardware addresses (GH-5254)#5290
Merged
Conversation
pythonGH-5254). (cherry picked from commit 6b273f7)
warsaw
approved these changes
Jan 24, 2018
Member
warsaw
left a comment
There was a problem hiding this comment.
This looks good to me. Let's see how CI finishes.
| if _node is not None: | ||
| if (_node is not None) and (0 <= _node < (1 << 48)): | ||
| return _node | ||
| assert False, '_random_getnode() returned invalid value: {}'.format(_node) |
Member
There was a problem hiding this comment.
Maybe; I think in this case it won't matter much either way since the whole point is to never reach this assert. :)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR backports #5254 to Python 3.6, per this discussion. I think I got the
cherry_pickerscript right.https://bugs.python.org/issue32502