Skip to content

bpo-28009: for AIX correct uuid.getnode() and add ctypes() based uuid._generate_time_safe #5183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aixtools wants to merge 8 commits into from
Closed

bpo-28009: for AIX correct uuid.getnode() and add ctypes() based uuid._generate_time_safe #5183

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7837745
* in Lib/uuid.py define ctypes() based definition of
aixtools Jan 14, 2018
f6d95f3
correct typo in News
aixtools Jan 14, 2018
44aa616
fix whitespace
aixtools Jan 14, 2018
64228cd
Ensure that 'lib' is defined before it is used
aixtools Jan 15, 2018
9d8148e
resolve conflicts in uuid.py
aixtools Feb 5, 2018
e6d1c0e
resolv conflict in uuid.py
aixtools Feb 5, 2018
dd5f39a
merge with new uuid.py from master
aixtools Feb 5, 2018
7b25dd3
uuid.py does not merge my additions, will try without the added effic…
aixtools Feb 5, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
resolv conflict in uuid.py
  • Loading branch information
@aixtools
aixtools committed Feb 5, 2018
commit e6d1c0ebb8e7761d51eecc461fd9951e95a99b27
2 changes: 1 addition & 1 deletion Lib/uuid.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -720,7 +720,7 @@ def _random_getnode():

_NODE_GETTERS_AIX = [_unix_getnode, _netstat_getnode]

def getnode():
def getnode(*, getters=None):
Copy link
Copy Markdown
Contributor

@native-api native-api May 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't see the purpose of any changes from here and further.

About this one specifically:

  • There's no discussion about an interface change or justification for it.
  • In any case, the getters arg is unused as the code is now.

"""Get the hardware address as a 48-bit positive integer.

The first time this runs, it may launch a separate program, which could
Expand Down