[3.6] bpo-29615: SimpleXMLRPCDispatcher no longer chains KeyError (or any other exception) to exception(s) raised in the dispatched methods.#478
Merged
Conversation
serhiy-storchaka
approved these changes
Mar 5, 2017
Contributor
Author
|
@serhiy-storchaka , I tried to add the proper cherry pick label myself, but could not find a place to do that. What am I missing, please? :) |
Member
|
@petr-motejlek only those with write permission can apply labels :) |
Contributor
Author
|
@Mariatta , cherry pick seemed to pick up some unrelated changes (from 3.7) and to get rid of them I had to manually edit some of the commits. So, I cleaned up the diff and squashed all changes into one simple commit |
Member
|
@Mariatta, I'm not well experienced with Git and GitHub. Is there something wrong with this PR? |
Member
|
@serhiy-storchaka I think it's fine :) You can merge it. Thanks. |
Mariatta
approved these changes
Mar 5, 2017
Contributor
Author
|
Thanks, guys :) |
Member
|
Thanks @Mariatta. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.