Fixes the upload script to purge the CDN correctly and display succes…#466
Merged
Conversation
zooba
commented
Mar 4, 2017
| <DownloadUrlBase Condition="'$(DownloadUrlBase)' == ''">$(TARGET)</DownloadUrlBase> | ||
| <DownloadUrlBase Condition="'$(DownloadUrlBase)' == ''">/srv/www.python.org/ftp/python</DownloadUrlBase> | ||
| <IncludeDoc Condition="'$(IncludeDoc)' == ''">true</IncludeDoc> | ||
| <BuildForRelease Condition="'$(BuildForRelease)' == ''">true</BuildForRelease> |
Member
Author
There was a problem hiding this comment.
This determines whether the version is "3.6.1rc1" (building for release) or "3.6.1dev1234" (not building for release).
Member
Author
There was a problem hiding this comment.
And if we have the wrong version number, we purge the wrong paths from the CDN.
zware
approved these changes
Mar 4, 2017
Member
zware
left a comment
There was a problem hiding this comment.
Passes my sanity check, but I can't actually test it and am not terribly familiar with it anyway.
duboviy
approved these changes
Mar 5, 2017
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 6, 2017
zooba
added a commit
to zooba/cpython
that referenced
this pull request
Mar 6, 2017
This was referenced Mar 6, 2017
zooba
added a commit
that referenced
this pull request
Mar 6, 2017
zooba
added a commit
that referenced
this pull request
Mar 6, 2017
ned-deily
pushed a commit
to ned-deily/cpython
that referenced
this pull request
Mar 21, 2017
…s output. (python#466) (python#497) (cherry picked from commit e544b40)
jaraco
pushed a commit
that referenced
this pull request
Dec 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…s output.