Skip to content

[3.6] bpo-32155: Bugfixes found by flake8 F841 warnings (GH-4608)#4610

Closed
miss-islington wants to merge 1 commit into
python:3.6from
miss-islington:backport-696b501-3.6
Closed

[3.6] bpo-32155: Bugfixes found by flake8 F841 warnings (GH-4608)#4610
miss-islington wants to merge 1 commit into
python:3.6from
miss-islington:backport-696b501-3.6

Conversation

@miss-islington
Copy link
Copy Markdown
Contributor

@miss-islington miss-islington commented Nov 28, 2017

  • distutils.config: Use the PyPIRCCommand.realm attribute if set
  • turtledemo: wait until macOS osascript command completes to not
    create a zombie process
  • Tools/scripts/treesync.py: declare 'default_answer' and
    'create_files' as globals to modify them with the command line
    arguments. Previously, -y, -n, -f and -a options had no effect.

flake8 warning: "F841 local variable 'p' is assigned to but never
used".
(cherry picked from commit 696b501)

https://bugs.python.org/issue32155

* distutils.config: Use the PyPIRCCommand.realm attribute if set
* turtledemo: wait until macOS osascript command completes to not
  create a zombie process
* Tools/scripts/treesync.py: declare 'default_answer' and
  'create_files' as globals to modify them with the command line
  arguments. Previously, -y, -n, -f and -a options had no effect.

flake8 warning: "F841 local variable 'p' is assigned to but never
used".
(cherry picked from commit 696b501)
@miss-islington
Copy link
Copy Markdown
Contributor Author

@vstinner: Backport status check is done, and it's a success ✅ .

@vstinner
Copy link
Copy Markdown
Member

The distutils.config are not correct: https://bugs.python.org/issue32155

So I close this PR and will redo it manually.

@vstinner vstinner closed this Nov 28, 2017
@miss-islington miss-islington deleted the backport-696b501-3.6 branch November 28, 2017 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants