Conversation
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept your contribution by verifying you have signed the PSF contributor agreement (CLA). Unfortunately we couldn't find an account corresponding to your GitHub username on bugs.python.org (b.p.o) to verify you have signed the CLA (this might be simply due to a missing "GitHub Name" entry in your b.p.o account settings). This is necessary for legal reasons before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. Thanks again to your contribution and we look forward to looking at it! |
Mariatta
left a comment
There was a problem hiding this comment.
Thanks! I think your proposed change makes sense. However I noticed you made the PR against the 3.6 branch. We work on the master branch first, and then backport it to the earlier versions.
Can you prepare another PR that targets the master branch?
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
|
I have made the requested changes; please review again. |
|
Thanks for making the requested changes! @Mariatta: please review the changes made to this pull request. |
"This feature" refers to automatic concatenation of string literals, not concatenation of variable and literal.