Skip to content

bpo-32034: Make asyncio.IncompleteReadError pickleable. #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
1st1 merged 3 commits into from
Nov 15, 2017
Merged

bpo-32034: Make asyncio.IncompleteReadError pickleable. #4409

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c8c5f15
bpo-32034: Make asyncio.IncompleteReadError pickleable.
Nov 15, 2017
c94b5b1
Make LimitOverrunError pickleable too
Nov 15, 2017
b698446
Test all pickle protocols
Nov 15, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Test all pickle protocols
  • Loading branch information
Yury Selivanov
Yury Selivanov committed Nov 15, 2017
commit b6984462847407f4d281a4845b35d419e48903f7
18 changes: 11 additions & 7 deletions Lib/test/test_asyncio/test_streams.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -848,16 +848,20 @@ def test___repr__transport(self):

def test_IncompleteReadError_pickleable(self):
e = asyncio.IncompleteReadError(b'abc', 10)
e2 = pickle.loads(pickle.dumps(e))
self.assertEqual(str(e), str(e2))
self.assertEqual(e.partial, e2.partial)
self.assertEqual(e.expected, e2.expected)
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.subTest(pickle_protocol=proto):
e2 = pickle.loads(pickle.dumps(e, protocol=proto))
self.assertEqual(str(e), str(e2))
self.assertEqual(e.partial, e2.partial)
self.assertEqual(e.expected, e2.expected)

def test_LimitOverrunError_pickleable(self):
e = asyncio.LimitOverrunError('message', 10)
e2 = pickle.loads(pickle.dumps(e))
self.assertEqual(str(e), str(e2))
self.assertEqual(e.consumed, e2.consumed)
for proto in range(pickle.HIGHEST_PROTOCOL + 1):
with self.subTest(pickle_protocol=proto):
e2 = pickle.loads(pickle.dumps(e, protocol=proto))
self.assertEqual(str(e), str(e2))
self.assertEqual(e.consumed, e2.consumed)


if __name__ == '__main__':
Expand Down