bpo-31810: Add smelly test to TravisCI#4054
Conversation
taleinat
left a comment
There was a problem hiding this comment.
The new script: section in .travis.yml seems to override the previous script: section, thus make smelly is being run instead of the test suite. It should probably just be added to the existing script: section.
|
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
taleinat
left a comment
There was a problem hiding this comment.
make smelly is now successfully run after the usual tests.
However, I'm not sure it will register as a failure with Travis CI in case a leaked symbol is found. It seems to me that it will just print some output, but that is not enough.
Find how to make Travis CI recognize this as a failed test when there are leaked symbols, and test that it actually works.
| # `-r -w` implicitly provided through `make buildbottest`. | ||
| - make buildbottest TESTOPTS="-j4 -uall,-cpu" | ||
| # Run `make smelly` to check if Python leaks any symbols | ||
| - make smelly |
There was a problem hiding this comment.
Oh, "make smelly" exits with an exit code 0 which means "success" even if libpython leaks a symbol :-( The change isn't as simple as I expected, sorry.
I wrote PR #4057 which reimplements "make smelly" in Python to get a non-zero exit code if libpython leaks a symbol.
There was a problem hiding this comment.
Oh yes, I was looking for a workaround for the same.
I'd pick something else now. Thanks :)
|
I merged my PR #4057. |
Adds
make smellyto Travishttps://bugs.python.org/issue31810