Skip to content

bpo-31567: fix more decorator markup in docs (GH-3959)#3966

Merged
merwok merged 3 commits into
python:masterfrom
merwok:fix-issue-31567
Oct 12, 2017
Merged

bpo-31567: fix more decorator markup in docs (GH-3959)#3966
merwok merged 3 commits into
python:masterfrom
merwok:fix-issue-31567

Conversation

@merwok
Copy link
Copy Markdown
Member

@merwok merwok commented Oct 12, 2017 •
edited by bedevere-bot
Loading

@merwok merwok self-assigned this Oct 12, 2017
merwok
merwok commented Oct 12, 2017
View reviewed changes
Comment thread Doc/library/typing.rst
.. decorator:: no_type_check

Decorator to indicate that annotations are not type hints.

Copy link
Copy Markdown
Member Author

@merwok merwok Oct 12, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing the text after this

@merwok merwok requested a review from berkerpeksag October 12, 2017 15:31
@merwok
Copy link
Copy Markdown
Member Author

merwok commented Oct 12, 2017

I may use this PR to also address feedback received on the ticket.

@merwok merwok merged commit 03b9537 into python:master Oct 12, 2017
@merwok merwok deleted the fix-issue-31567 branch October 12, 2017 16:29
merwok pushed a commit that referenced this pull request Oct 12, 2017
@miss-islington @merwok
[3.6] bpo-31567: add or fix decorator markup in docs (GH-3959) (GH-3966)
205dd4e 
(cherry picked from commit 0e61e67)
@ilevkivskyi
Copy link
Copy Markdown
Member

ilevkivskyi commented Dec 5, 2017

@merwok Please mention me and/or Guido when making changes to typing-related files (this will simplify life since typing is still developed in a separate repo).

@merwok
Copy link
Copy Markdown
Member Author

merwok commented Dec 5, 2017

Sure! Could you have your names in the code owners file?

@ilevkivskyi
Copy link
Copy Markdown
Member

ilevkivskyi commented Dec 5, 2017

Could you have your names in the code owners file?

This is an interesting idea. I am not a core-dev but @gvanrossum maybe you can add yourself as a code owner for typing.py and test_typing.py?

@gvanrossum
Copy link
Copy Markdown
Member

gvanrossum commented Dec 5, 2017

I'm happy to be listed as owner for typing.py etc. but I don't know how this is administered.

@merwok
Copy link
Copy Markdown
Member Author

merwok commented Dec 5, 2017

This file maps repo file patterns to github usernames or team names:
https://github.com/python/cpython/blob/master/.github/CODEOWNERS

@gvanrossum gvanrossum mentioned this pull request Dec 5, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag

Assignees

@merwok merwok

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@merwok @ilevkivskyi @gvanrossum @the-knights-who-say-ni @bedevere-bot