Skip to content

bpo-31701: faulthandler.enable() registers exc handler as last #3928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
vstinner wants to merge 1 commit into from
Closed

bpo-31701: faulthandler.enable() registers exc handler as last #3928

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Misc/NEWS.d/next/Library/2017-10-09-12-22-57.bpo-31701.Ti8o41.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
On Windows, faulthandler.enable() now registers the exception handler as the
last handler to be called, rather than the first to be called. It prevents
handled C++ exceptions to be logged by faulthandler.
2 changes: 1 addition & 1 deletion Modules/faulthandler.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,7 +457,7 @@ faulthandler_enable(void)

#ifdef MS_WINDOWS
assert(fatal_error.exc_handler == NULL);
fatal_error.exc_handler = AddVectoredExceptionHandler(1, faulthandler_exc_handler);
fatal_error.exc_handler = AddVectoredExceptionHandler(0, faulthandler_exc_handler);
#endif
return 0;
}
Expand Down