Skip to content

bpo-31458: Update Misc/NEWS link in What's New page - #3555

Merged
Mariatta merged 2 commits into
masterfrom
Mariatta-bpo-31458
Sep 13, 2017
Merged

bpo-31458: Update Misc/NEWS link in What's New page#3555
Mariatta merged 2 commits into
masterfrom
Mariatta-bpo-31458

Conversation

@Mariatta

@Mariatta Mariatta commented Sep 13, 2017 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

Link to Misc/NEWS.d instead

https://bugs.python.org/issue31458

@Mariatta Mariatta added needs backport to 3.6 skip news docs Documentation in the Doc dir labels Sep 13, 2017
@Mariatta
Mariatta merged commit 1b8f612 into master Sep 13, 2017
@miss-islington

miss-islington commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.6.
🐍🍒⛏🤖

@miss-islington

miss-islington commented Sep 13, 2017

Copy link
Copy Markdown
Contributor

Sorry, @Mariatta, I could not cleanly backport this to 3.6 due to a conflict.
Please backport using cherry_picker on command line.

@Mariatta
Mariatta deleted the Mariatta-bpo-31458 branch September 13, 2017 23:47
Mariatta added a commit to Mariatta/cpython that referenced this pull request Sep 14, 2017
@Mariatta
bpo-31458: Update Misc/NEWS link in What's New page (pythonGH-3555)
601685f 
Update the link from Misc/NEWS to Misc/NEWS.d

(cherry picked from commit 1b8f612)
Mariatta added a commit to Mariatta/cpython that referenced this pull request Sep 14, 2017
@Mariatta
[3.6] bpo-31458: Update Misc/NEWS link in What's New page (pythonGH-3555
0cb6f47 
)

Update the link from Misc/NEWS to Misc/NEWS.d.
(cherry picked from commit 1b8f612)
@bedevere-bot

bedevere-bot commented Sep 14, 2017

Copy link
Copy Markdown

GH-3560 is a backport of this pull request to the 3.6 branch.

Mariatta added a commit that referenced this pull request Sep 14, 2017
@Mariatta
[3.6] bpo-31458: Update Misc/NEWS link in What's New page (GH-3555) (G…
905e4ef 
…H-3560)

Update the link from Misc/NEWS to Misc/NEWS.d
(cherry picked from commit 1b8f612)
merwok
merwok reviewed Sep 14, 2017
View reviewed changes
Comment thread Doc/whatsnew/index.rst
2.0.rst

The "Changelog" is a HTML version of the file :source:`Misc/NEWS` which
The "Changelog" is a HTML version of the file :source:`Misc/NEWS.d` which

@merwok merwok Sep 14, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NEWS.d is a directory with many files; could the text here be confusing or will people understand what is meant?

@Mariatta Mariatta Sep 14, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm.. good point. So what should this be changed into?

@bitdancer bitdancer Sep 15, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest "is an HTML version of a file built from the contents of the directory tree..." You could even link "file built" to blurb.

@Mariatta Mariatta Sep 16, 2017

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I made a new PR: #3617

@bitdancer

bitdancer commented Sep 15, 2017

Copy link
Copy Markdown
Member

On a tangentially related note, why are there .rst files and a next/Build directory checked in?

@merwok

merwok commented Sep 15, 2017 •
edited
Loading

Copy link
Copy Markdown
Member

Because next/Build contains news files for changes related to building CPython :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bitdancer bitdancer bitdancer left review comments
@merwok merwok merwok left review comments

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@Mariatta @miss-islington @bedevere-bot @bitdancer @merwok @the-knights-who-say-ni