Skip to content

correct some initialization code #3376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
benjaminp merged 1 commit into from
Sep 6, 2017
Merged

correct some initialization code #3376

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
correct initialization code 
Explicitly initialize struct members rather than relying on compiler extensions.
  • Loading branch information
@benjaminp
benjaminp committed Sep 6, 2017
commit b9a2da7c16f45305cfc3c785be0834258a3da7fa
2 changes: 1 addition & 1 deletion Python/pylifecycle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ extern void _PyGILState_Init(PyInterpreterState *, PyThreadState *);
extern void _PyGILState_Fini(void);
#endif /* WITH_THREAD */

_PyRuntimeState _PyRuntime = {};
_PyRuntimeState _PyRuntime = {0, 0};

void
_PyRuntime_Initialize(void)
Expand Down
3 changes: 1 addition & 2 deletions Python/pystate.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,8 +37,7 @@ extern "C" {
void
_PyRuntimeState_Init(_PyRuntimeState *runtime)
{
_PyRuntimeState initial = {};
*runtime = initial;
memset(runtime, 0, sizeof(*runtime));

_PyObject_Initialize(&runtime->obj);
_PyMem_Initialize(&runtime->mem);
Expand Down