Skip to content

bpo-47178: Improve the implementations of Sequence.index and MutableSequence.extend in collections.abc #32150

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
geryogam wants to merge 8 commits into from
Closed

bpo-47178: Improve the implementations of Sequence.index and MutableSequence.extend in collections.abc #32150

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
c00713d
Move additional code out of a try clause in function Sequence.index
geryogam Mar 28, 2022
23debfc
Remove unnecessary call to built-in function reversed
geryogam Mar 30, 2022
a0683e5
Simplify the implementation of function Sequence.index with slicing
geryogam Mar 30, 2022
3a43558
Update Lib/_collections_abc.py
geryogam Mar 30, 2022
0ae076f
Remove temporary self copy when a sequence extends itself in MutableS…
geryogam Mar 30, 2022
32115db
Remove temporary self copy when a sequence extends itself in MutableS…
geryogam Mar 30, 2022
f988b02
Undo the change to Sequence.__reversed__
geryogam Mar 30, 2022
87cb707
Merge branch 'main' into patch-32
geryogam Mar 30, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 9 additions & 17 deletions Lib/_collections_abc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1013,20 +1013,10 @@ def index(self, value, start=0, stop=None):
Supporting start and stop arguments is optional, but
recommended.
'''
if start is not None and start < 0:
start = max(len(self) + start, 0)
if stop is not None and stop < 0:
stop += len(self)

i = start
while stop is None or i < stop:
try:
v = self[i]
if v is value or v == value:
return i
except IndexError:
break
i += 1
for i in range(len(self))[start:stop]:
Comment thread
geryogam marked this conversation as resolved.
v = self[i]
Comment thread
geryogam marked this conversation as resolved.
if v is value or v == value:
return i
raise ValueError

def count(self, value):
Expand Down Expand Up @@ -1094,9 +1084,11 @@ def reverse(self):
def extend(self, values):
'S.extend(iterable) -- extend sequence by appending elements from the iterable'
if values is self:
values = list(values)
for v in values:
self.append(v)
for i in range(len(values)):
self.append(values[i])
Comment thread
geryogam marked this conversation as resolved.
else:
for v in values:
self.append(v)

def pop(self, index=-1):
'''S.pop([index]) -> item -- remove and return item at index (default last).
Expand Down