Skip to content

bpo-47000: Add locale.getencoding() #32068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 13 commits into from
Apr 9, 2022
Merged

bpo-47000: Add locale.getencoding() #32068

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
cd4bccc
bpo-47000: Add locale.get_encoding()
methane Mar 20, 2022
aaa8956
get_encoding() -> getencoding()
methane Mar 31, 2022
104206a
fix TextIOWrapper.__init__
methane Mar 31, 2022
8b50eb1
get_encoding -> getencoding
methane Mar 31, 2022
a0204c2
Use _Py_STR for "utf-8"
methane Apr 4, 2022
08413f1
Update the doc.
methane Apr 6, 2022
f61b622
Add news
methane Apr 6, 2022
1c60e5b
Apply proposed changes.
methane Apr 6, 2022
7397493
Fix doc error.
methane Apr 6, 2022
44730dd
Apply suggestions from code review
methane Apr 7, 2022
7720b10
UTF-8 -> utf-8
methane Apr 7, 2022
104008d
Fix test_utf8_mode
methane Apr 7, 2022
a8e50bd
Update based on suggestions
methane Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Use _Py_STR for "utf-8"
  • Loading branch information
@methane
methane committed Apr 4, 2022
commit a0204c25f4cc6bd91beba56cba0395f6d4906ac6
8 changes: 4 additions & 4 deletions Modules/_io/textio.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1145,10 +1145,10 @@ _io_TextIOWrapper___init___impl(textio *self, PyObject *buffer,
}
}
if (encoding == NULL && self->encoding == NULL) {
const PyPreConfig *preconfig = &_PyRuntime.preconfig;
if (preconfig->utf8_mode) {
// TODO: Use _Py_STR
self->encoding = PyUnicode_FromString("utf-8");
if (_PyRuntime.preconfig.utf8_mode) {
_Py_DECLARE_STR(utf_8, "utf-8");
self->encoding = &_Py_STR(utf_8);
Py_INCREF(self->encoding);
Comment thread
methane marked this conversation as resolved.
Outdated
}
else {
self->encoding = _Py_GetLocaleEncodingObject();
Expand Down
5 changes: 4 additions & 1 deletion Python/fileutils.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,10 @@ _Py_device_encoding(int fd)
return PyUnicode_FromFormat("cp%u", (unsigned int)cp);
#else
if (_PyRuntime.preconfig.utf8_mode) {
return PyUnicode_FromString("utf-8"); //TODO: Use _Py_STR
_Py_DECLARE_STR(utf_8, "utf-8");
PyObject *encoding = &_Py_STR(utf_8);
Py_INCREF(encoding);
return encoding;
}
return _Py_GetLocaleEncodingObject();
#endif
Expand Down