Skip to content

bpo-35540 dataclasses.asdict support defaultdict fields #32056

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ericvsmith merged 6 commits into from
Oct 7, 2022
Merged

bpo-35540 dataclasses.asdict support defaultdict fields #32056

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7567680
bpo-35540: Fix dataclasses.asdict support for defaultdict fields
kwsp Mar 22, 2022
82b41dc
fix blurb
kwsp Mar 24, 2022
3fe8873
added tests for asdict() with defaultdict
kwsp May 4, 2022
1efb31d
Merge branch 'fix-issue-35540' of github.com:kwsp/cpython into fix-is…
kwsp May 4, 2022
95c957f
Merge branch 'main' into fix-issue-35540
ericvsmith Oct 4, 2022
4fcb8d0
check 'default_factory' attr on the type
kwsp Oct 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
check 'default_factory' attr on the type
  • Loading branch information
@kwsp
kwsp committed Oct 6, 2022
commit 4fcb8d0830d18e5c67aefcf2bcd1b3464f397eb8
2 changes: 1 addition & 1 deletion Lib/dataclasses.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1309,7 +1309,7 @@ def _asdict_inner(obj, dict_factory):
# generator (which is not true for namedtuples, handled
# above).
return type(obj)(_asdict_inner(v, dict_factory) for v in obj)
elif isinstance(obj, dict) and hasattr(obj, 'default_factory'):
elif isinstance(obj, dict) and hasattr(type(obj), 'default_factory'):
# obj is a defaultdict, which has a different constructor from
# dict as it requires the default_factory as its first arg.
# https://bugs.python.org/issue35540
Expand Down