Skip to content

bpo-47000: Make io.text_encoding() respects UTF-8 mode #32003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 11 commits into from
Apr 4, 2022
Merged

bpo-47000: Make io.text_encoding() respects UTF-8 mode #32003

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
96eeaeb
bpo-47000: Make io.text_encoding() respects UTF-8 mode.
methane Mar 20, 2022
b8f751f
Fix refcounting
methane Mar 20, 2022
bafa263
make clinic
methane Mar 20, 2022
de5867f
Update Modules/_io/_iomodule.c
methane Mar 23, 2022
52045fc
Update Modules/_io/_iomodule.c
methane Mar 31, 2022
37f640a
test: ignore utf-8 vs UTF-8
methane Mar 31, 2022
addff87
Update _iomodule.c
methane Mar 31, 2022
11c614c
Update the doc
methane Apr 3, 2022
e6f46fa
Remove trailing spaces.
methane Apr 3, 2022
ff8eb27
Update docstring
methane Apr 3, 2022
ce48c4a
make clinic
methane Apr 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update docstring
  • Loading branch information
@methane
methane committed Apr 3, 2022
commit ff8eb2796c69b1ad726c177a3a7235db81753745
6 changes: 3 additions & 3 deletions Lib/_pyio.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,9 +44,9 @@ def text_encoding(encoding, stacklevel=2):
"""
A helper function to choose the text encoding.

When encoding is not None, just return it.
Otherwise, return the default text encoding (i.e. "locale", or "utf-8"
if UTF-8 mode is enabled).
When encoding is not None, this function returns it.
Otherwise, this function returns the default text encoding
(i.e. "locale" or "utf-8" depends on UTF-8 mode).

This function emits an EncodingWarning if *encoding* is None and
sys.flags.warn_default_encoding is true.
Expand Down
6 changes: 3 additions & 3 deletions Modules/_io/_iomodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -457,9 +457,9 @@ _io.text_encoding

A helper function to choose the text encoding.

When encoding is not None, just return it.
Otherwise, return the default text encoding (i.e. "locale", or "utf-8"
if UTF-8 mode is enabled).
When encoding is not None, this function returns it.
Otherwise, this function returns the default text encoding
(i.e. "locale" or "utf-8" depends on UTF-8 mode).

This function emits an EncodingWarning if encoding is None and
sys.flags.warn_default_encoding is true.
Expand Down