Skip to content

bpo-43292: Fix file leak in ET.iterparse() when not exhausted #31696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 3 commits into from
Mar 7, 2022
Merged

bpo-43292: Fix file leak in ET.iterparse() when not exhausted #31696

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1495ccd
bpo-43292: Fix file leak in iterparse when not exhausted
jacobtylerwalls Mar 5, 2022
b29dba7
Update ElementTree.py
serhiy-storchaka Mar 6, 2022
f532022
Update Lib/test/test_xml_etree.py
serhiy-storchaka Mar 6, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update Lib/test/test_xml_etree.py
  • Loading branch information
@serhiy-storchaka
serhiy-storchaka authored Mar 6, 2022
commit f532022dc684dcb768afc1cb3d6717c96aac1ed9
3 changes: 3 additions & 0 deletions Lib/test/test_xml_etree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,6 +663,9 @@ def test_iterparse(self):
it = iterparse(TESTFN)
del it

Comment thread
serhiy-storchaka marked this conversation as resolved.
with self.assertRaises(FileNotFoundError):
iterparse("nonexistent")

def test_writefile(self):
elem = ET.Element("tag")
elem.text = "text"
Expand Down