Skip to content

bpo-46921: Vectorcall support for super() #31687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 4 commits into from
Mar 6, 2022
Merged

bpo-46921: Vectorcall support for super() #31687

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a88ec4c
vectorcall support for super()
Fidget-Spinner Mar 4, 2022
896eb36
Use _PyArg_NoKwnames instead
Fidget-Spinner Mar 4, 2022
0bbe8d6
Address code review
Fidget-Spinner Mar 5, 2022
4416fe6
Add a tests
Fidget-Spinner Mar 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
vectorcall support for super()
  • Loading branch information
@Fidget-Spinner
Fidget-Spinner committed Mar 4, 2022
commit a88ec4c9add981713576d4db6abe6015a2cd3223
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Core and Builtins/2022-03-05-00-43-22.bpo-46921.tyuPeB.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Support vectorcall for ``super()``. Patch by Ken Jin.
53 changes: 51 additions & 2 deletions Objects/typeobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9000,19 +9000,28 @@ super_init_without_args(_PyInterpreterFrame *cframe, PyCodeObject *co,
return 0;
}

static int super_init_impl(PyObject *self, PyTypeObject *type, PyObject *obj);

static int
super_init(PyObject *self, PyObject *args, PyObject *kwds)
{
superobject *su = (superobject *)self;
PyTypeObject *type = NULL;
PyObject *obj = NULL;
PyTypeObject *obj_type = NULL;

if (!_PyArg_NoKeywords("super", kwds))
return -1;
if (!PyArg_ParseTuple(args, "|O!O:super", &PyType_Type, &type, &obj))
return -1;
if (super_init_impl(self, type, obj) < 0) {
return -1;
}
return 0;
}

static inline int
super_init_impl(PyObject *self, PyTypeObject *type, PyObject *obj) {
superobject *su = (superobject *)self;
PyTypeObject *obj_type = NULL;
if (type == NULL) {
/* Call super(), without args -- fill in from __class__
and first local variable on the stack. */
Expand Down Expand Up @@ -9072,6 +9081,45 @@ super_traverse(PyObject *self, visitproc visit, void *arg)
return 0;
}

static PyObject *
super_vectorcall(PyObject *self, PyObject *const *args,
size_t nargsf, PyObject *kwnames)
{
assert(PyType_Check(self));
if (kwnames != NULL) {
Comment thread
Fidget-Spinner marked this conversation as resolved.
Outdated
PyErr_SetString(PyExc_TypeError, "super() takes no keyword arguments");
return NULL;
}

PyTypeObject *type = NULL;
PyObject *obj = NULL;
PyTypeObject *self_type = (PyTypeObject *)self;
Py_ssize_t nargs = PyVectorcall_NARGS(nargsf);
PyObject *su = self_type->tp_alloc(self_type, 0);
if (su == NULL) {
return NULL;
}
if (nargs != 0) {
Comment thread
Fidget-Spinner marked this conversation as resolved.
PyObject *arg0 = args[0];
if (!PyType_Check(arg0)) {
PyErr_Format(PyExc_TypeError,
"super() argument 1 must be a type, not %.200s", Py_TYPE(arg0)->tp_name);
goto fail;
}
type = (PyTypeObject *)arg0;
}
if (nargs == 2) {
obj = args[1];
}
if (super_init_impl(su, type, obj) < 0) {
goto fail;
}
return su;
fail:
Py_DECREF(su);
return NULL;
}

PyTypeObject PySuper_Type = {
PyVarObject_HEAD_INIT(&PyType_Type, 0)
"super", /* tp_name */
Expand Down Expand Up @@ -9114,4 +9162,5 @@ PyTypeObject PySuper_Type = {
PyType_GenericAlloc, /* tp_alloc */
PyType_GenericNew, /* tp_new */
PyObject_GC_Del, /* tp_free */
.tp_vectorcall = (vectorcallfunc)super_vectorcall,
Comment thread
Fidget-Spinner marked this conversation as resolved.
};