Skip to content

bpo-46841: Use inline caching for COMPARE_OP #31622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 4 commits into from
Mar 1, 2022
Merged

bpo-46841: Use inline caching for COMPARE_OP #31622

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0aa49c9
Use inline caching for COMPARE_OP
brandtbucher Feb 28, 2022
f6808e0
blurb add
brandtbucher Feb 28, 2022
dc37052
Clean things up a bit
brandtbucher Feb 28, 2022
bf4cf3d
More cleanup
brandtbucher Feb 28, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean things up a bit
  • Loading branch information
@brandtbucher
brandtbucher committed Feb 28, 2022
commit dc37052769071d3909650b18ac66277071c3403f
2 changes: 0 additions & 2 deletions Include/internal/pycore_code.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,7 +82,6 @@ typedef struct {
_Py_CODEUNIT counter;
} _PyUnpackSequenceCache;


#define INLINE_CACHE_ENTRIES_UNPACK_SEQUENCE \
CACHE_ENTRIES(_PyUnpackSequenceCache)

Expand All @@ -91,7 +90,6 @@ typedef struct {
_Py_CODEUNIT mask;
} _PyCompareOpCache;


#define INLINE_CACHE_ENTRIES_COMPARE_OP CACHE_ENTRIES(_PyCompareOpCache)

/* Maximum size of code to quicken, in code units. */
Expand Down
2 changes: 2 additions & 0 deletions Python/specialize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2059,6 +2059,8 @@ void
_Py_Specialize_CompareOp(PyObject *lhs, PyObject *rhs, _Py_CODEUNIT *instr,
int oparg)
{
assert(_PyOpcode_InlineCacheEntries[COMPARE_OP] ==
INLINE_CACHE_ENTRIES_COMPARE_OP);
_PyCompareOpCache *cache = (_PyCompareOpCache *)(instr + 1);
int next_opcode = _Py_OPCODE(instr[INLINE_CACHE_ENTRIES_COMPARE_OP + 1]);
if (next_opcode != POP_JUMP_IF_FALSE && next_opcode != POP_JUMP_IF_TRUE) {
Expand Down