Skip to content

bpo-46845: Reduce dict size when all keys are Unicode. #31564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
methane merged 9 commits into from
Mar 1, 2022
Merged

bpo-46845: Reduce dict size when all keys are Unicode. #31564

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
b0bdccf
bpo-46845: Reduce dict size for unicode keys
methane Feb 23, 2022
65d748b
fixup
methane Feb 25, 2022
e504a21
fix some comments
methane Feb 25, 2022
00f502c
Add news and what's new.
methane Feb 25, 2022
a92c420
Simplify dict_keys, dict_values, and dict_items
methane Feb 25, 2022
0cfec8c
fixup
methane Feb 25, 2022
e7d9ba0
Add _PyDict_FromItems()
methane Feb 27, 2022
ad0db8d
Merge branch 'main' into dict-stringkeys
methane Mar 1, 2022
ff38c4b
fixup
methane Mar 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix some comments
  • Loading branch information
@methane
methane committed Feb 25, 2022
commit e504a21715de6a8b2b622ab236e068880fcb64a2
4 changes: 2 additions & 2 deletions Objects/dictnotes.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ A values array
Tunable Dictionary Parameters
-----------------------------

See comments for PyDict_MINSIZE_SPLIT, PyDict_MINSIZE_COMBINED,
USABLE_FRACTION and GROWTH_RATE in dictobject.c
See comments for PyDict_MINSIZE, USABLE_FRACTION and GROWTH_RATE in
dictobject.c

Tune-ups should be measured across a broad range of applications and
use cases. A change to any parameter will help in some situations and
Expand Down
4 changes: 2 additions & 2 deletions Objects/dictobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,8 @@ Size of indices is dk_size. Type of each index in indices is vary on dk_size:
* int32 for 2**16 <= dk_size <= 2**31
* int64 for 2**32 <= dk_size

dk_entries is array of PyDictKeyEntry. Its size is USABLE_FRACTION(dk_size).
DK_ENTRIES(dk) can be used to get pointer to entries.
dk_entries is array of PyDictKeyEntry when dk_kind == DICT_KEYS_GENERAL or
PyDictUnicodeEntry otherwise. Its length is USABLE_FRACTION(dk_size).

NOTE: Since negative value is used for DKIX_EMPTY and DKIX_DUMMY, type of
dk_indices entry is signed integer and int16 is used for table which
Expand Down