bpo-34429: Noted TemporaryFile behavior on non-Posix/non-Cygwin systems#31547
Merged
Conversation
Member
|
I agree, how about ‘is an alias for’? |
iritkatriel
reviewed
Feb 24, 2022
Co-authored-by: Irit Katriel <1055913+iritkatriel@users.noreply.github.com>
iritkatriel
approved these changes
Feb 25, 2022
Contributor
|
Thanks @slateny for the PR, and @iritkatriel for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10. |
|
GH-31567 is a backport of this pull request to the 3.10 branch. |
|
GH-31568 is a backport of this pull request to the 3.9 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2022
…ms (pythonGH-31547) (cherry picked from commit 53ecf9e) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Feb 25, 2022
…ms (pythonGH-31547) (cherry picked from commit 53ecf9e) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
asvetlov
pushed a commit
that referenced
this pull request
Feb 26, 2022
hello-adam
pushed a commit
to hello-adam/cpython
that referenced
this pull request
Jun 2, 2022
…ms (pythonGH-31547) (cherry picked from commit 53ecf9e) Co-authored-by: slateny <46876382+slateny@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I applied the suggested wording, but is it be accurate to say
TemporaryFile'behaves exactly like'NamedTemporaryFile? Saying 'behaves exactly like' seems to imply thatTemporaryFileis an imitation of sorts, while the implementation ofTemporaryFile = NamedTemporaryFilewould appear to make them completely identicalhttps://bugs.python.org/issue34429