Skip to content

bpo-46841: Use *inline* caching for BINARY_OP #31543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
markshannon merged 8 commits into from
Feb 25, 2022
Merged

bpo-46841: Use *inline* caching for BINARY_OP #31543

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
42c9907
Use inline caching for BINARY_OP instructions
brandtbucher Feb 23, 2022
a446858
Bump the magic number
brandtbucher Feb 23, 2022
0393b0d
Fixup
brandtbucher Feb 23, 2022
8fd41b7
*facepalm*
brandtbucher Feb 24, 2022
4cc3467
blurb add
brandtbucher Feb 24, 2022
a59d97c
Use dedicated cache structures
brandtbucher Feb 24, 2022
6b0e5ba
Catch up with main
brandtbucher Feb 24, 2022
1aa079c
Use a run-time assert instead of a build-time one
brandtbucher Feb 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fixup
  • Loading branch information
@brandtbucher
brandtbucher committed Feb 23, 2022
commit 0393b0d93a29f38ed2776d86036aba5975ad95d1
8 changes: 4 additions & 4 deletions Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -148,16 +148,16 @@ write_instr(_Py_CODEUNIT *codestr, struct instr *instruction, int ilen)
int caches = _PyOpcode_InlineCacheEntries[opcode];
switch (ilen - caches) {
case 4:
*codestr++ = _Py_MAKECODEUNIT(EXTENDED_ARG, (oparg >> 24) & 0xff);
*codestr++ = _Py_MAKECODEUNIT(EXTENDED_ARG, (oparg >> 24) & 0xFF);
/* fall through */
case 3:
*codestr++ = _Py_MAKECODEUNIT(EXTENDED_ARG, (oparg >> 16) & 0xff);
*codestr++ = _Py_MAKECODEUNIT(EXTENDED_ARG, (oparg >> 16) & 0xFF);
/* fall through */
case 2:
*codestr++ = _Py_MAKECODEUNIT(EXTENDED_ARG, (oparg >> 8) & 0xff);
*codestr++ = _Py_MAKECODEUNIT(EXTENDED_ARG, (oparg >> 8) & 0xFF);
/* fall through */
case 1:
*codestr++ = _Py_MAKECODEUNIT(opcode, oparg & 0xff);
*codestr++ = _Py_MAKECODEUNIT(opcode, oparg & 0xFF);
break;
default:
Py_UNREACHABLE();
Expand Down