Skip to content

bpo-46329: Streamline calling sequence a bit.#31465

Merged
markshannon merged 8 commits into
python:mainfrom
faster-cpython:streamline-call-shape
Feb 21, 2022
Merged

bpo-46329: Streamline calling sequence a bit.#31465
markshannon merged 8 commits into
python:mainfrom
faster-cpython:streamline-call-shape

Conversation

@markshannon

@markshannon markshannon commented Feb 21, 2022

Copy link
Copy Markdown
Member

This PR:

  1. Removes the call_shape struct, except the kw_names field for keyword arguments.
  2. Moves the KW_NAMES instruction before the PRECALL.
  3. Changes the operand of CALL to match that of PRECALL.

See faster-cpython/ideas#267 (comment) for rationale.

https://bugs.python.org/issue46329

@markshannon markshannon force-pushed the streamline-call-shape branch from 1a9cdfb to 77328c7 Compare February 21, 2022 11:42
@markshannon markshannon added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 21, 2022
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @markshannon for commit 77328c7 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Feb 21, 2022
@markshannon

Copy link
Copy Markdown
Member Author

The failures seem to be the usual asyncio flakiness and maybe a deadlock on the s390x buildbot.
The ARM64 Windows seems to be failing while linking.
All unrelated to this PR, although there are a couple of Windows compiler warnings to fix.

@markshannon markshannon merged commit 59585d6 into python:main Feb 21, 2022
@markshannon markshannon deleted the streamline-call-shape branch September 26, 2023 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants