Skip to content

gh-86943: implement pathlib.WindowsPath.is_mount() #31458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 5 commits into from
Aug 5, 2022
Merged

gh-86943: implement pathlib.WindowsPath.is_mount() #31458

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
897fd22
bpo-42777: implement `pathlib.WindowsPath.is_mount()`
barneygale Feb 21, 2022
c61c72c
Fix Windows tests
barneygale Feb 21, 2022
726be72
Merge branch 'main' into bpo-42777-pathlib-is-mount-on-windows
barneygale Jul 30, 2022
97a9b72
Address feedback, bring up-to-date.
barneygale Jul 30, 2022
8749589
Remove test that '/\x00` (posix) and 'c:\\\x00' aren't mounts.
barneygale Jul 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix Windows tests
  • Loading branch information
@barneygale
barneygale committed Feb 21, 2022
commit c61c72cb317557fedb667d5311054e286474bb70
4 changes: 2 additions & 2 deletions Lib/test/test_pathlib.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2288,8 +2288,8 @@ def test_is_mount(self):
self.assertTrue(R.is_mount())
if os_helper.can_symlink():
self.assertFalse((P / 'linkA').is_mount())
self.assertIs(self.cls('/\udfff').is_mount(), False)
self.assertIs(self.cls('/\x00').is_mount(), False)
self.assertIs((R / '\udfff').is_mount(), False)
self.assertIs((R / '\x00').is_mount(), False)

def test_is_symlink(self):
P = self.cls(BASE)
Expand Down