Skip to content

bpo-46730: Add more info to @property AttributeError messages #31311

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sweeneyde merged 12 commits into from
Feb 16, 2022
Merged

bpo-46730: Add more info to @property AttributeError messages #31311

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
06df3a7
bpo-46730: Make @property AttributeError unique and sensible
Feb 13, 2022
0b1ac64
bpo-46730: Add more details on property origin to the AttributeError
Feb 13, 2022
e86f544
bpo-46730: Make AttributeError show self.__qualname__ instead of owne…
Feb 14, 2022
921d3e5
bpo-46730: Adjusted documentation according to the latest changes
Feb 14, 2022
f1cae0c
bpo-46730: Fix regex dot in tests
Feb 14, 2022
83cae88
bpo-46730: Make changes comply with PEP 7
Feb 14, 2022
7594277
bpo-46730: Change preposition from "in" to "of" in error
Feb 14, 2022
7399805
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 14, 2022
236e579
Update ACKS
Feb 14, 2022
1de53bb
bpo-46730: Remove "of type of" from the message
Feb 15, 2022
3d931a1
bpo-46730: Change the order of words
Feb 15, 2022
bc90175
bpo-46730: Fix doctest for property
Feb 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
bpo-46730: Adjusted documentation according to the latest changes
  • Loading branch information
Alexander Lakeev committed Feb 14, 2022
commit 921d3e50149024dfa0db9d3b1cc8f9099da8a1ab
6 changes: 3 additions & 3 deletions Doc/howto/descriptor.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -991,17 +991,17 @@ here is a pure Python equivalent:
if obj is None:
return self
if self.fget is None:
raise AttributeError(f'unreadable property {self._name}')
raise AttributeError(f"property '{self._name}' has no getter")
return self.fget(obj)

def __set__(self, obj, value):
if self.fset is None:
raise AttributeError(f"no setter was defined for property {self._name}")
raise AttributeError(f"property '{self._name}' has no setter")
self.fset(obj, value)

def __delete__(self, obj):
if self.fdel is None:
raise AttributeError(f"no deleter was defined for property {self._name}")
raise AttributeError(f"property '{self._name}' has no deleter")
self.fdel(obj)

def getter(self, fget):
Expand Down
6 changes: 3 additions & 3 deletions Objects/descrobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1463,17 +1463,17 @@ class property(object):
if inst is None:
return self
if self.__get is None:
raise AttributeError, "unreadable attribute"
raise AttributeError, "property has no getter"
return self.__get(inst)

def __set__(self, inst, value):
if self.__set is None:
raise AttributeError, "can't set attribute"
raise AttributeError, "property has no setter"
return self.__set(inst, value)

def __delete__(self, inst):
if self.__del is None:
raise AttributeError, "can't delete attribute"
raise AttributeError, "property has no deleter"
return self.__del(inst)

*/
Expand Down