Skip to content

bpo-46707: Avoid potential exponential backtracking in some syntax errors#31241

Merged
pablogsal merged 1 commit into
python:mainfrom
pablogsal:memo_rules
Feb 10, 2022
Merged

bpo-46707: Avoid potential exponential backtracking in some syntax errors#31241
pablogsal merged 1 commit into
python:mainfrom
pablogsal:memo_rules

Conversation

@pablogsal

@pablogsal pablogsal commented Feb 10, 2022 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Member

@pablogsal pablogsal added the needs backport to 3.10 only security fixes label Feb 10, 2022
@pablogsal
pablogsal force-pushed the memo_rules branch 3 times, most recently from a3398b3 to b1ae7b5 Compare February 10, 2022 03:13
@pablogsal pablogsal changed the title Avoid potential exponential backtracking in some syntax errors bpo-46707: Avoid potential exponential backtracking in some syntax errors Feb 10, 2022
@pablogsal

pablogsal commented Feb 10, 2022

Copy link
Copy Markdown
Member Author

CC: @tonybaloney

@pablogsal
pablogsal merged commit b71dc71 into python:main Feb 10, 2022
@pablogsal
pablogsal deleted the memo_rules branch February 10, 2022 03:37
@miss-islington

miss-islington commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington

miss-islington commented Feb 10, 2022

Copy link
Copy Markdown
Contributor

Sorry, @pablogsal, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b71dc71905ab674ccaa4a56230d17a28f61c325c 3.10

pablogsal added a commit to pablogsal/cpython that referenced this pull request Feb 10, 2022
@pablogsal
[3.10] bpo-46707: Avoid potential exponential backtracking in some sy…
f6dd231 
…ntax errors (pythonGH-31241).

(cherry picked from commit b71dc71)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@bedevere-bot

bedevere-bot commented Feb 10, 2022

Copy link
Copy Markdown

GH-31242 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 10, 2022
pablogsal added a commit that referenced this pull request Feb 10, 2022
@pablogsal
[3.10] bpo-46707: Avoid potential exponential backtracking in some sy…
9b23f8f 
…ntax errors (GH-31241). (GH-31242)

(cherry picked from commit b71dc71)

Co-authored-by: Pablo Galindo Salgado <Pablogsal@gmail.com>
@tonybaloney

tonybaloney commented Feb 11, 2022

Copy link
Copy Markdown
Contributor

[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[$[[[[[[[[[[[[ appears to hit the same bug, it looks like this covers it, but there isn't a test

@pablogsal

pablogsal commented Feb 11, 2022 •
edited
Loading

Copy link
Copy Markdown
Member Author

[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[[$[[[[[[[[[[[[ appears to hit the same bug, it looks like this covers it, but there isn't a test

Both are handled by the same rule path so one covers the other. I will expand the test to also cover this in any case.

Thanks for the suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Assignees

@pablogsal pablogsal

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@pablogsal @miss-islington @bedevere-bot @tonybaloney @the-knights-who-say-ni