Skip to content

bpo-46642: explicitly disallow typing.TypeVar instance subclassing #31148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serhiy-storchaka merged 7 commits into from
Jun 25, 2022
+81 −39
Merged

bpo-46642: explicitly disallow typing.TypeVar instance subclassing #31148

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
c51f48e
explicitly disallow typing.TypeVar subclassing
GBeauregard Feb 5, 2022
3659772
📜🤖 Added by blurb_it.
blurb-it[bot] Feb 5, 2022
a3c54d5
make test match regex
GBeauregard Feb 6, 2022
3b68cda
Merge branch 'python:main' into fix-typevar-test
GBeauregard Feb 6, 2022
a7a6074
Merge branch 'main' into fix-typevar-test
serhiy-storchaka Jun 21, 2022
bf233d1
More explicit errors and more tests.
serhiy-storchaka Jun 21, 2022
a854d32
Update a NEWS entry.
serhiy-storchaka Jun 21, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
explicitly disallow typing.TypeVar subclassing 
The existing test covering this case passed only incidentally. We
explicitly disallow doing this and add a proper error message.
  • Loading branch information
@GBeauregard
GBeauregard committed Feb 5, 2022
commit c51f48ee1a964c9e225b8d95db45336a91b439b6
3 changes: 3 additions & 0 deletions Lib/typing.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -818,6 +818,9 @@ def __init__(self, name, *constraints, bound=None,
if def_mod != 'typing':
self.__module__ = def_mod

def __mro_entries__(self, bases):
Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Mar 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be added not here, but in _TypeVarLike. ParamSpec instances are not subclassable too.

Copy link
Copy Markdown
Member

@serhiy-storchaka serhiy-storchaka Mar 12, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And add it also in TypeVarTuple.

Copy link
Copy Markdown
Contributor Author

@GBeauregard GBeauregard Mar 18, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the feedback! I'll get to this soon and ping you when done (I'm currently in the process of moving across the country and starting a job)

raise TypeError("Cannot subclass an instance of TypeVar.")


class ParamSpecArgs(_Final, _Immutable, _root=True):
"""The args for a ParamSpec object.
Expand Down