Skip to content

bpo-43224: Implement PEP 646 changes to genericaliasobject.c #31019

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Fidget-Spinner merged 19 commits into from
Mar 12, 2022
Merged

bpo-43224: Implement PEP 646 changes to genericaliasobject.c #31019

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
e8bb03b
PEP 646: Implement changes to genericaliasobject.c
mrahtz Jan 30, 2022
9cb2aec
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 30, 2022
b3fa489
Swap an assignment and an INCREF to a NewRef
mrahtz Jan 30, 2022
ec81d44
Fix cast whitespace
mrahtz Jan 30, 2022
968b3fb
Add NULL check
mrahtz Jan 30, 2022
4aa94df
Remove restriction that only `tuple` can be unpacked
mrahtz Jan 30, 2022
c256bc9
Remove test which is no longer necessary
mrahtz Jan 30, 2022
e4a72b4
Fix news
mrahtz Feb 1, 2022
742d283
Import suggestions from kumaraditya303 from previous PR
mrahtz Feb 1, 2022
d4d97b3
Use public PyObject_GC_Track
mrahtz Feb 1, 2022
7f06e2a
Use public PyObject_GC_UnTrack
mrahtz Feb 1, 2022
6bf3caa
fix gc
kumaraditya303 Feb 8, 2022
06308d2
Merge pull request #6 from kumaraditya303/pep646-tuple
mrahtz Feb 14, 2022
e554309
Implement tp_clear; set StopIteration explicitly; add curly braces
mrahtz Feb 14, 2022
eaf8083
Add more tests
mrahtz Feb 14, 2022
38dca54
Remove references to starred *tuples* specifically (since we removed …
mrahtz Feb 15, 2022
1102d27
Merge branch 'main' into pep646-tuple
mrahtz Mar 10, 2022
eda60f9
Merge branch 'main' into pep646-tuple
mrahtz Mar 10, 2022
5fe058e
Merge branch 'main' into pep646-tuple
mrahtz Mar 11, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix gc
  • Loading branch information
@kumaraditya303
kumaraditya303 authored Feb 8, 2022
commit 6bf3caa0e7483b28f97802f02606a844c33bff57
12 changes: 11 additions & 1 deletion Objects/genericaliasobject.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -659,14 +659,24 @@ ga_iternext(gaiterobject *gi) {
static void
ga_iter_dealloc(gaiterobject *gi) {
PyObject_GC_UnTrack(gi);
Py_XDECREF(gi->obj);
PyObject_GC_Del(gi);
Comment thread
mrahtz marked this conversation as resolved.
}

static int
ga_iter_traverse(gaiterobject *gi, visitproc visit, void *arg)
{
Py_VISIT(gi->obj);
return 0;
}

static PyTypeObject Py_GenericAliasIterType = {
Comment thread
mrahtz marked this conversation as resolved.
PyVarObject_HEAD_INIT(&PyType_Type, 0)
.tp_name = "generic_alias_iter",
.tp_name = "generic_alias_iterator",
.tp_basicsize = sizeof(gaiterobject),
.tp_iter = PyObject_SelfIter,
.tp_iternext = (iternextfunc)ga_iternext,
.tp_traverse = (traverseproc)ga_iter_traverse,
.tp_dealloc = (destructor)ga_iter_dealloc,
.tp_flags = Py_TPFLAGS_DEFAULT | Py_TPFLAGS_HAVE_GC,
};
Expand Down