Skip to content

bpo-40077: Convert _pickle module to use heap types. #30884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
CharlieZhao95 wants to merge 6 commits into from
Closed

bpo-40077: Convert _pickle module to use heap types. #30884

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4a8a3e7
Replace Pickler_Type & Unpickler_Type with heap allocated types:
CharlieZhao95 Jan 22, 2022
f5f0d39
Fix ref.leak in Pickler & Unpickler
CharlieZhao95 Jan 24, 2022
ae949a1
Convert _pickle module to use PyType_FromModuleAndSpec()
CharlieZhao95 Jan 25, 2022
2905ef4
Add heap types to traverse, clear and free functions
CharlieZhao95 Jan 25, 2022
6df22b4
Replace `find_pickle_state_by_type()` with `get_pickle_state_by_class()`
CharlieZhao95 Jan 25, 2022
e3d2f18
📜🤖 Added by blurb_it.
blurb-it[bot] Jan 25, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add heap types to traverse, clear and free functions
  • Loading branch information
@CharlieZhao95
CharlieZhao95 committed Jan 25, 2022
commit 2905ef4fbee43af76aaa52227ab799fa52a26d59
6 changes: 6 additions & 0 deletions Modules/_pickle.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,6 +229,9 @@ _Pickle_ClearState(PickleState *st)
Py_CLEAR(st->partial);
Py_CLEAR(st->Pickler_Type);
Py_CLEAR(st->Unpickler_Type);
Py_CLEAR(st->Pdata_Type);
Py_CLEAR(st->PicklerMemoProxyType);
Py_CLEAR(st->UnpicklerMemoProxyType);
}

/* Initialize the given pickle module state. */
Expand Down Expand Up @@ -7912,6 +7915,9 @@ pickle_traverse(PyObject *m, visitproc visit, void *arg)
Py_VISIT(st->partial);
Py_VISIT(st->Pickler_Type);
Py_VISIT(st->Unpickler_Type);
Py_VISIT(st->Pdata_Type);
Py_VISIT(st->PicklerMemoProxyType);
Py_VISIT(st->UnpicklerMemoProxyType);
return 0;
}

Expand Down