When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

I have made the requested changes; please review again.

Thanks for making the requested changes!

@pganssle: please review the changes made to this pull request.

I don't understand the CI failures. Bedevere seems to think this is a PR against a maintenance branch (it's not) and that it's got no issue number (though it does have one). Maybe rebase and see if that fixes it?

@jaraco: Status check is done, and it's a success ✅ .

Sorry, I can't merge this PR. Reason: 4 of 6 required status checks are expected..

Good call. Bedevere seems happy with it now, so I expect it to merge automatically once tests pass.

@jaraco: Status check is done, and it's a failure ❌ .

@jaraco: Status check is done, and it's a success ✅ .

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot ARM64 Windows Non-Debug 3.x has failed when building commit 00b2b57.

What do you need to do:

1. Don't panic.
2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/730/builds/2799) and take a look at the build logs.
4. Check if the failure is related to this commit (00b2b57) or if it is a false positive.
5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/730/builds/2799

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

394 tests OK.

10 slowest tests:

• test_peg_generator: 4 min 10 sec
• test_multiprocessing_spawn: 1 min 52 sec
• test_concurrent_futures: 1 min 34 sec
• test_mmap: 1 min 25 sec
• test_asyncio: 1 min 9 sec
• test_socket: 1 min
• test_io: 43.4 sec
• test_distutils: 42.2 sec
• test_urllib2_localnet: 38.3 sec
• test_imaplib: 34.2 sec

1 test altered the execution environment:
test_asyncio

37 tests skipped:
test_curses test_dbm_gnu test_dbm_ndbm test_devpoll test_epoll
test_fcntl test_fork1 test_gdb test_grp test_idle test_ioctl
test_kqueue test_multiprocessing_fork
test_multiprocessing_forkserver test_nis test_openpty
test_ossaudiodev test_pipes test_poll test_posix test_pty test_pwd
test_readline test_resource test_spwd test_syslog test_tcl
test_threadsignals test_tix test_tk test_ttk_guionly
test_ttk_textonly test_turtle test_wait3 test_wait4
test_xxtestfuzz test_zipfile64

Total duration: 12 min 5 sec

Traceback (most recent call last):
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\asyncio\proactor_events.py", line 116, in __del__
    self.close()
    ^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\asyncio\proactor_events.py", line 108, in close
    self._loop.call_soon(self._call_connection_lost, None)
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\asyncio\base_events.py", line 745, in call_soon
    self._check_closed()
    ^^^^^^^^^^^^^^^^^^^^
  File "C:\Workspace\buildarea\3.x.linaro-win-arm64.nondebug\build\Lib\asyncio\base_events.py", line 506, in _check_closed
    raise RuntimeError('Event loop is closed')
    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
RuntimeError: Event loop is closed
k

At first blush, that error looks to be a false positive. I can't tell if there's an error or solely a "altered execution environment" failure. It's conceivable that something about test_asyncio is accessing the zoneinfo module and triggering resource issues in how zoneinfo returns open file resources. But I don't see anything of the sort in the tracebacks or test names. Worse, test_asyncio is a package and not a module, so the locus of the failure is diffuse. Still, I confirmed that test_asyncio package makes no reference of zoneinfo, so I'm going to assume the failure is spurious. I'll peek at neighboring buildbot failures to see if I can confirm a failure prior to this commit or a success after.

Hmm. Many tests prior to the commit all pass, suggesting this commit was highly unlucky or is in fact implicated. Still awaiting a result for after. I do see that test_proactor_events is implicated in the warnings.

Good news. The subsequent build succeeded.

So it was just noise. Declaring success.