Skip to content

bpo-46038: Mark /configure file as generated in .gitattributes #30031

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
arhadthedev wants to merge 2 commits into from
Closed

bpo-46038: Mark /configure file as generated in .gitattributes #30031

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
85968c3
Mark configure file as generated in .gitattributes
arhadthedev Dec 10, 2021
2ade650
Address review: mark aclocal.m4 as generated
arhadthedev Dec 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Mark configure file as generated in .gitattributes 
configure is regenerated from configure.ac using a custom container
with appropriate version of tools (quay.io/tiran/cpython_autoconf
by Christian Heimes).

As a result, configure falls into the same category as files generated
by Argument Clinic, Freeze and Parser/asdl_c.py. Due to size and churn
of these artifacts, they are marked in .gitattributes as generated so
GitHub Pull Request Diff Viewer collapses them into a short
notification. This commit does the same for configure.

Actually, configure diff is so large that sometimes it crosses
a threshold and GitHub collapses it by force with "Large diffs are not
rendered by default" or even "xxx additions, yyy deletions not shown
because the diff is too large. Please use a local Git client to view
these changes". See GH-29756 as an extreme example and
<https://github.com/python/cpython/commits/main/configure> for
an average.
  • Loading branch information
@arhadthedev
arhadthedev committed Dec 10, 2021
commit 85968c352733a20817947d0b7d4080885bdf12ab
1 change: 1 addition & 0 deletions .gitattributes
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ Include/token.h linguist-generated=true
Lib/token.py linguist-generated=true
Parser/token.c linguist-generated=true
Programs/test_frozenmain.h linguist-generated=true
configure linguist-generated=true
Comment thread
arhadthedev marked this conversation as resolved.

# Language aware diff headers
# https://tekin.co.uk/2020/10/better-git-diff-output-for-ruby-python-elixir-and-more
Expand Down