Skip to content

bpo-46015: Fixes calculation of sys.path in a venv on Windows#29992

Merged
zooba merged 3 commits into
python:mainfrom
zooba:bpo-46015
Dec 8, 2021
Merged

bpo-46015: Fixes calculation of sys.path in a venv on Windows#29992
zooba merged 3 commits into
python:mainfrom
zooba:bpo-46015

Conversation

@zooba

@zooba zooba commented Dec 8, 2021

Copy link
Copy Markdown
Member

@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit e54f47c 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2021

@ericsnowcurrently ericsnowcurrently left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pablogsal

Copy link
Copy Markdown
Member

Seems that some of the Windows buildbots still fail :(

https://buildbot.python.org/all/#/builders/577/builds/479

@zooba

zooba commented Dec 8, 2021

Copy link
Copy Markdown
Member Author

Yeah, I think I have a repro, but only by manually breaking my build directory. At least it's a step closer!

Generate pybuilddir.txt earlier in build
@zooba zooba requested a review from a team as a code owner December 8, 2021 18:57
@zooba zooba added the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2021
@bedevere-bot

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @zooba for commit 2eccccb 🤖

If you want to schedule another build, you need to add the ":hammer: test-with-buildbots" label again.

@bedevere-bot bedevere-bot removed the 🔨 test-with-buildbots Test PR w/ buildbots; report in status section label Dec 8, 2021
@zooba

zooba commented Dec 8, 2021

Copy link
Copy Markdown
Member Author

My current guess is that the older version of MSBuild on the buildbot is running two final steps in a different order, which causes the latter one to fail first and abort the necessary one. For some reason it isn't causing the whole build to fail, and so we're left with a build that doesn't have its pybuilddir.txt file.

@zooba

zooba commented Dec 8, 2021

Copy link
Copy Markdown
Member Author

Looks like that has done it. I'd assume we'll get more issues post-release, but that's kind of the point of an alpha release.

@zooba zooba merged commit 7778116 into python:main Dec 8, 2021
@zooba zooba deleted the bpo-46015 branch December 8, 2021 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants