bpo-46015: Fixes calculation of sys.path in a venv on Windows#29992
Merged
Conversation
Member
|
Seems that some of the Windows buildbots still fail :( |
Member
Author
|
Yeah, I think I have a repro, but only by manually breaking my build directory. At least it's a step closer! |
Generate pybuilddir.txt earlier in build
Member
Author
|
My current guess is that the older version of MSBuild on the buildbot is running two final steps in a different order, which causes the latter one to fail first and abort the necessary one. For some reason it isn't causing the whole build to fail, and so we're left with a build that doesn't have its |
Member
Author
|
Looks like that has done it. I'd assume we'll get more issues post-release, but that's kind of the point of an alpha release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue46015