Skip to content

bpo-45459: Add Py_buffer to limited API #29991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
miss-islington merged 12 commits into from
Feb 2, 2022
Merged

bpo-45459: Add Py_buffer to limited API #29991

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
549fcdb
bpo-45459: Add Py_buffer to limited API
tiran Oct 18, 2021
526c58c
Move Py_buffer APIs to buffer.h
tiran Oct 18, 2021
1440b94
Hide typo alias with limited API
tiran Oct 18, 2021
cf98a23
Make Py_buffer public
tiran Dec 8, 2021
0e67e2c
Update stable_abi.txt and run make regen-limited-abi
tiran Dec 8, 2021
d516781
Add simple tests for Py_buffer stable ABI
tiran Dec 8, 2021
c1391cf
Add PyMemoryView_FromBuffer to limited API
tiran Dec 8, 2021
92d2ea5
Add docs
tiran Dec 8, 2021
7df9317
Document PyObject_CopyData
tiran Feb 2, 2022
0ab2a44
Address Petr's code review of xxlimited.c
tiran Feb 2, 2022
98a4ee5
Make Py_Buffer struct anon
tiran Feb 2, 2022
6119c2b
Remove forward declaration of Py_Buffer
tiran Feb 2, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update stable_abi.txt and run make regen-limited-abi
  • Loading branch information
@tiran
tiran committed Feb 2, 2022
commit 0e67e2c94be6af3632c158dc8c6e5142a109d314
12 changes: 12 additions & 0 deletions Doc/data/stable_abi.dat
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,14 @@ function,PyArg_ValidateKeywordArguments,3.2,
var,PyBaseObject_Type,3.2,
function,PyBool_FromLong,3.2,
var,PyBool_Type,3.2,
function,PyBuffer_FillContiguousStrides,3.11,
function,PyBuffer_FillInfo,3.11,
function,PyBuffer_FromContiguous,3.11,
function,PyBuffer_GetPointer,3.11,
function,PyBuffer_IsContiguous,3.11,
function,PyBuffer_Release,3.11,
function,PyBuffer_SizeFromFormat,3.11,
function,PyBuffer_ToContiguous,3.11,
var,PyByteArrayIter_Type,3.2,
function,PyByteArray_AsString,3.2,
function,PyByteArray_Concat,3.2,
Expand Down Expand Up @@ -476,8 +484,10 @@ function,PyObject_CallMethodObjArgs,3.2,
function,PyObject_CallNoArgs,3.10,
function,PyObject_CallObject,3.2,
function,PyObject_Calloc,3.7,
function,PyObject_CheckBuffer,3.11,
function,PyObject_CheckReadBuffer,3.2,
function,PyObject_ClearWeakRefs,3.2,
function,PyObject_CopyData,3.11,
Comment thread
tiran marked this conversation as resolved.
Outdated
function,PyObject_DelItem,3.2,
function,PyObject_DelItemString,3.2,
function,PyObject_Dir,3.2,
Expand All @@ -495,6 +505,7 @@ function,PyObject_GenericSetDict,3.7,
function,PyObject_GetAIter,3.10,
function,PyObject_GetAttr,3.2,
function,PyObject_GetAttrString,3.2,
function,PyObject_GetBuffer,3.11,
function,PyObject_GetItem,3.2,
function,PyObject_GetIter,3.2,
function,PyObject_HasAttr,3.2,
Expand Down Expand Up @@ -832,6 +843,7 @@ var,Py_UTF8Mode,3.8,
function,Py_VaBuildValue,3.2,
var,Py_Version,3.11,
function,Py_XNewRef,3.10,
type,Py_buffer,3.11,
type,Py_intptr_t,3.2,
type,Py_ssize_t,3.2,
type,Py_uintptr_t,3.2,
Expand Down
11 changes: 11 additions & 0 deletions Lib/test/test_stable_abi_ctypes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,14 @@ def test_available_symbols(self):
"PyBaseObject_Type",
"PyBool_FromLong",
"PyBool_Type",
"PyBuffer_FillContiguousStrides",
"PyBuffer_FillInfo",
"PyBuffer_FromContiguous",
"PyBuffer_GetPointer",
"PyBuffer_IsContiguous",
"PyBuffer_Release",
"PyBuffer_SizeFromFormat",
"PyBuffer_ToContiguous",
"PyByteArrayIter_Type",
"PyByteArray_AsString",
"PyByteArray_Concat",
Expand Down Expand Up @@ -470,8 +478,10 @@ def test_available_symbols(self):
"PyObject_CallNoArgs",
"PyObject_CallObject",
"PyObject_Calloc",
"PyObject_CheckBuffer",
"PyObject_CheckReadBuffer",
"PyObject_ClearWeakRefs",
"PyObject_CopyData",
"PyObject_DelItem",
"PyObject_DelItemString",
"PyObject_Dir",
Expand All @@ -489,6 +499,7 @@ def test_available_symbols(self):
"PyObject_GetAIter",
"PyObject_GetAttr",
"PyObject_GetAttrString",
"PyObject_GetBuffer",
"PyObject_GetItem",
"PyObject_GetIter",
"PyObject_HasAttr",
Expand Down
26 changes: 26 additions & 0 deletions Misc/stable_abi.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2191,6 +2191,32 @@ function PyType_GetQualName
data PyStructSequence_UnnamedField
added 3.11

# Add stable Py_buffer API in Python 3.11 (https://bugs.python.org/issue45459)
struct Py_buffer
added 3.11
function PyObject_CheckBuffer
added 3.11
function PyObject_GetBuffer
added 3.11
function PyBuffer_GetPointer
added 3.11
function PyBuffer_SizeFromFormat
added 3.11
function PyBuffer_ToContiguous
added 3.11
function PyBuffer_FromContiguous
added 3.11
function PyObject_CopyData
added 3.11
function PyBuffer_IsContiguous
added 3.11
function PyBuffer_FillContiguousStrides
added 3.11
function PyBuffer_FillInfo
added 3.11
function PyBuffer_Release
added 3.11

# (Detailed comments aren't really needed for further entries: from here on
# we can use version control logs.)

Expand Down
11 changes: 11 additions & 0 deletions PC/python3dll.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,14 @@ EXPORT_FUNC(PyArg_ValidateKeywordArguments)
EXPORT_FUNC(PyArg_VaParse)
EXPORT_FUNC(PyArg_VaParseTupleAndKeywords)
EXPORT_FUNC(PyBool_FromLong)
EXPORT_FUNC(PyBuffer_FillContiguousStrides)
EXPORT_FUNC(PyBuffer_FillInfo)
EXPORT_FUNC(PyBuffer_FromContiguous)
EXPORT_FUNC(PyBuffer_GetPointer)
EXPORT_FUNC(PyBuffer_IsContiguous)
EXPORT_FUNC(PyBuffer_Release)
EXPORT_FUNC(PyBuffer_SizeFromFormat)
EXPORT_FUNC(PyBuffer_ToContiguous)
EXPORT_FUNC(PyByteArray_AsString)
EXPORT_FUNC(PyByteArray_Concat)
EXPORT_FUNC(PyByteArray_FromObject)
Expand Down Expand Up @@ -426,8 +434,10 @@ EXPORT_FUNC(PyObject_CallMethodObjArgs)
EXPORT_FUNC(PyObject_CallNoArgs)
EXPORT_FUNC(PyObject_CallObject)
EXPORT_FUNC(PyObject_Calloc)
EXPORT_FUNC(PyObject_CheckBuffer)
EXPORT_FUNC(PyObject_CheckReadBuffer)
EXPORT_FUNC(PyObject_ClearWeakRefs)
EXPORT_FUNC(PyObject_CopyData)
EXPORT_FUNC(PyObject_DelItem)
EXPORT_FUNC(PyObject_DelItemString)
EXPORT_FUNC(PyObject_Dir)
Expand All @@ -445,6 +455,7 @@ EXPORT_FUNC(PyObject_GenericSetDict)
EXPORT_FUNC(PyObject_GetAIter)
EXPORT_FUNC(PyObject_GetAttr)
EXPORT_FUNC(PyObject_GetAttrString)
EXPORT_FUNC(PyObject_GetBuffer)
EXPORT_FUNC(PyObject_GetItem)
EXPORT_FUNC(PyObject_GetIter)
EXPORT_FUNC(PyObject_HasAttr)
Expand Down