Skip to content

bpo-46001: Change OverflowError to RecursionError in JSON library docstrings#29943

Merged
serhiy-storchaka merged 1 commit into
python:mainfrom
SnoopJ:bpo-46001_doc-json-overflowerror
Dec 7, 2021
Merged

bpo-46001: Change OverflowError to RecursionError in JSON library docstrings#29943
serhiy-storchaka merged 1 commit into
python:mainfrom
SnoopJ:bpo-46001_doc-json-overflowerror

Conversation

@SnoopJ

@SnoopJ SnoopJ commented Dec 6, 2021 •
edited by bedevere-bot
Loading

Copy link
Copy Markdown
Contributor

This PR brings the documentation of the json library (specifically the exception raised when check_circular=False) into agreement with the test suite

https://bugs.python.org/issue46001

https://bugs.python.org/issue46001

@AlexWaygood AlexWaygood added the docs Documentation in the Doc dir label Dec 6, 2021
@serhiy-storchaka serhiy-storchaka merged commit 8db0652 into python:main Dec 7, 2021
@miss-islington

miss-islington commented Dec 7, 2021

Copy link
Copy Markdown
Contributor

Thanks @SnoopJeDi for the PR, and @serhiy-storchaka for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 7, 2021
@SnoopJ @miss-islington
bpo-46001: Change OverflowError to RecursionError in JSON library doc…
81ea25c 
…strings (pythonGH-29943)

(cherry picked from commit 8db0652)

Co-authored-by: James Gerity <snoopjedi@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Dec 7, 2021
@bedevere-bot

bedevere-bot commented Dec 7, 2021

Copy link
Copy Markdown

GH-29952 is a backport of this pull request to the 3.10 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 7, 2021
@SnoopJ @miss-islington
bpo-46001: Change OverflowError to RecursionError in JSON library doc…
b986e70 
…strings (pythonGH-29943)

(cherry picked from commit 8db0652)

Co-authored-by: James Gerity <snoopjedi@gmail.com>
@bedevere-bot

bedevere-bot commented Dec 7, 2021

Copy link
Copy Markdown

GH-29953 is a backport of this pull request to the 3.9 branch.

miss-islington added a commit that referenced this pull request Dec 7, 2021
@miss-islington @SnoopJ
bpo-46001: Change OverflowError to RecursionError in JSON library doc…
15da2a2 
…strings (GH-29943)

(cherry picked from commit 8db0652)

Co-authored-by: James Gerity <snoopjedi@gmail.com>
miss-islington added a commit that referenced this pull request Dec 7, 2021
@miss-islington @SnoopJ
bpo-46001: Change OverflowError to RecursionError in JSON library doc…
2e36083 
…strings (GH-29943)

(cherry picked from commit 8db0652)

Co-authored-by: James Gerity <snoopjedi@gmail.com>
@bedevere-bot

bedevere-bot commented Dec 7, 2021

Copy link
Copy Markdown

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot x86 Gentoo Non-Debug with X 3.10 has failed when building commit 15da2a2.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/698/builds/518) and take a look at the build logs.
  4. Check if the failure is related to this commit (15da2a2) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/698/builds/518

Summary of the results of the build (if available):

== Tests result: ENV CHANGED ==

417 tests OK.

10 slowest tests:

  • test_peg_generator: 13 min 38 sec
  • test_multiprocessing_spawn: 3 min 46 sec
  • test_concurrent_futures: 3 min 36 sec
  • test_tokenize: 2 min 48 sec
  • test_unparse: 2 min 32 sec
  • test_asyncio: 2 min 27 sec
  • test_lib2to3: 2 min 12 sec
  • test_multiprocessing_forkserver: 2 min 2 sec
  • test_multiprocessing_fork: 1 min 26 sec
  • test_signal: 1 min 14 sec

1 test altered the execution environment:
test_ftplib

9 tests skipped:
test_devpoll test_ioctl test_kqueue test_msilib test_startfile
test_winconsoleio test_winreg test_winsound test_zipfile64

Total duration: 33 min 36 sec

Click to see traceback logs 
Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/threading.py", line 1009, in _bootstrap_inner
    self.run()
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/test/test_ftplib.py", line 298, in run
    asyncore.loop(timeout=0.1, count=1)
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/asyncore.py", line 214, in loop
    poll_fun(timeout, map)
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/asyncore.py", line 157, in poll
    read(obj)
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/asyncore.py", line 94, in read
    obj.handle_error()
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/test/test_ftplib.py", line 140, in handle_error
    raise Exception
Exception


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/multiprocessing/resource_tracker.py", line 209, in main
    cache[rtype].remove(name)
KeyError: '/psm_3d56fd2d'


Traceback (most recent call last):
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/asyncore.py", line 90, in read
    obj.handle_read_event()
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/asyncore.py", line 427, in handle_read_event
    self.handle_read()
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/asynchat.py", line 179, in handle_read
    self.found_terminator()
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/test/test_ftplib.py", line 135, in found_terminator
    method(arg)
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/test/test_ftplib.py", line 160, in cmd_pasv
    conn, addr = sock.accept()
  File "/buildbot/buildarea/cpython/3.10.ware-gentoo-x86.nondebug/build/Lib/socket.py", line 293, in accept
    fd, addr = self._accept()
TimeoutError: timed out

@snoopjedi snoopjedi mannequin mentioned this pull request Apr 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@SnoopJ @miss-islington @bedevere-bot @serhiy-storchaka @the-knights-who-say-ni @AlexWaygood