Skip to content

bpo-45607: Make it possible to enrich exception displays via setting their __note__ field #29880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iritkatriel merged 19 commits into from
Dec 3, 2021
Merged

bpo-45607: Make it possible to enrich exception displays via setting their __note__ field #29880

Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
78f9a9a
bpo-45607: Add __note__ field to BaseException
iritkatriel Nov 29, 2021
2f380bf
add test_note in test_exceptions
iritkatriel Dec 1, 2021
8ab5e13
add to traceback
iritkatriel Dec 1, 2021
c6e07e3
add exception group test
iritkatriel Dec 1, 2021
5bf6edd
remove redundant assertion
iritkatriel Dec 1, 2021
263b753
support multi-line notes as well. Test for empty string in note
iritkatriel Dec 1, 2021
36b6022
📜🤖 Added by blurb_it.
blurb-it[bot] Dec 1, 2021
35ba887
add to doc
iritkatriel Dec 1, 2021
85b537d
whatsnew in 3.11
iritkatriel Dec 1, 2021
12ba64e
backticks in doc
iritkatriel Dec 1, 2021
cbb52dc
remove extra newline in test
iritkatriel Dec 1, 2021
8592206
fix expected exception sizes in test_sys
iritkatriel Dec 1, 2021
3adba26
whitespace
iritkatriel Dec 2, 2021
cf1c0e8
Py_NewRef
iritkatriel Dec 2, 2021
32a174b
PEP7
iritkatriel Dec 2, 2021
ea1b40a
rst formatting
iritkatriel Dec 2, 2021
a96c8d6
single quotes
iritkatriel Dec 2, 2021
77858af
tidy up type check for note (Kumar's review comments)
iritkatriel Dec 2, 2021
7a5e37e
add del test
iritkatriel Dec 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
tidy up type check for note (Kumar's review comments)
  • Loading branch information
@iritkatriel
iritkatriel committed Dec 2, 2021
commit 77858af5c0d7e407ae0d9b9d7c580cc0c53cb2ba
4 changes: 2 additions & 2 deletions Objects/exceptions.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,8 +236,8 @@ BaseException_set_note(PyBaseExceptionObject *self, PyObject *note,
PyErr_SetString(PyExc_TypeError, "__note__ may not be deleted");
return -1;
}
Comment thread
iritkatriel marked this conversation as resolved.
else if (note != Py_None && !PyUnicode_Check(note)) {
PyErr_SetString(PyExc_TypeError, "__note__ must be an str or None");
else if (note != Py_None && !PyUnicode_CheckExact(note)) {
PyErr_SetString(PyExc_TypeError, "__note__ must be a string or None");
return -1;
}

Expand Down