Skip to content

bpo-41818: Add os.login_tty() for *nix. #29658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gpshead merged 17 commits into from
May 5, 2022
Merged

bpo-41818: Add os.login_tty() for *nix. #29658

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
576bc5a
Add os.login_tty() for Unix.
8vasu Nov 20, 2021
d30e66b
📜🤖 Added by blurb_it.
blurb-it[bot] Nov 20, 2021
089cb17
Merge branch 'main' into login_tty
tiran Dec 4, 2021
1b02fd7
Re-generate configure script using preferred version of autoconf.
8vasu Dec 6, 2021
0f4d5b3
Use #ifdef instead of #if defined() whenever possible.
8vasu Jan 16, 2022
7b27681
Copy posixmodule.c.h from branch 'main' to prepare to fix merge conflict
8vasu Jan 17, 2022
f5b28a0
Merge branch 'main' into login_tty
8vasu Jan 17, 2022
b8effd2
Generate posixmodule.c.h using argument clinic
8vasu Jan 17, 2022
8492291
Remove the archaic approach of opening a tty device file to make it t…
8vasu May 2, 2022
c3becc2
Resolve conflict in posixmodule.c.h
8vasu May 2, 2022
ec717f7
Copy posixmodule.c.h from branch 'main' to prepare to fix merge conflict
8vasu May 2, 2022
995746e
Merge branch 'main' into login_tty
8vasu May 2, 2022
b2bcbc1
Generate posixmodule.c.h using Argument Clinic
8vasu May 2, 2022
e35e7a0
Remove the old news file.
8vasu May 2, 2022
6a033b8
📜🤖 Added by blurb_it.
blurb-it[bot] May 2, 2022
dc69763
Merge branch 'main' into login_tty
gpshead May 5, 2022
5ad23a2
fixup the argument clinic footer (regen)
gpshead May 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Re-generate configure script using preferred version of autoconf. 
Signed-off-by: Soumendra Ganguly <soumendraganguly@gmail.com>
  • Loading branch information
@8vasu
8vasu committed Dec 6, 2021
commit 1b02fd7e6ed92e70d0193579e2dfce7dc07df25d
2 changes: 1 addition & 1 deletion Modules/clinic/posixmodule.c.h
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions Modules/posixmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7212,9 +7212,9 @@ os_sched_getaffinity_impl(PyObject *module, pid_t pid)
#endif

#if defined(HAVE_OPENPTY) || defined(HAVE_FORKPTY) || defined(HAVE_LOGIN_TTY) || defined(HAVE_DEV_PTMX)
#if defined(HAVE_PTY_H)
#ifdef HAVE_PTY_H
#include <pty.h>
#if defined(HAVE_UTMP_H)
#ifdef HAVE_UTMP_H
#include <utmp.h>
#endif /* HAVE_UTMP_H */
#elif defined(HAVE_LIBUTIL_H)
Expand Down
63 changes: 61 additions & 2 deletions configure
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

9 changes: 3 additions & 6 deletions configure.ac
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2256,7 +2256,7 @@ AC_CHECK_HEADERS([ \
sys/random.h sys/resource.h sys/select.h sys/sendfile.h sys/socket.h sys/soundcard.h sys/stat.h \
sys/statvfs.h sys/sys_domain.h sys/syscall.h sys/sysmacros.h sys/termio.h sys/time.h sys/times.h \
sys/types.h sys/uio.h sys/un.h sys/utsname.h sys/wait.h sys/xattr.h sysexits.h syslog.h \
termios.h util.h utime.h \
termios.h util.h utime.h utmp.h \
])
AC_HEADER_DIRENT
AC_HEADER_MAJOR
Expand Down Expand Up @@ -4315,11 +4315,8 @@ AC_CHECK_FUNCS(openpty,,
AC_CHECK_LIB(bsd,openpty, [AC_DEFINE(HAVE_OPENPTY) LIBS="$LIBS -lbsd"])
)
)
AC_CHECK_FUNCS(login_tty,,
AC_CHECK_LIB(util,login_tty,
[AC_DEFINE(HAVE_LOGIN_TTY) LIBS="$LIBS -lutil"],
AC_CHECK_LIB(bsd,login_tty, [AC_DEFINE(HAVE_LOGIN_TTY) LIBS="$LIBS -lbsd"])
)
AC_SEARCH_LIBS([login_tty], [util],
[AC_DEFINE([HAVE_LOGIN_TTY], [1], [Define to 1 if you have the `login_tty' function.])]
)
AC_CHECK_FUNCS(forkpty,,
AC_CHECK_LIB(util,forkpty,
Expand Down
6 changes: 6 additions & 0 deletions pyconfig.h.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -715,6 +715,9 @@
/* Define to 1 if you have the `log2' function. */
#undef HAVE_LOG2

/* Define to 1 if you have the `login_tty' function. */
#undef HAVE_LOGIN_TTY

/* Define to 1 if the system has the type `long double'. */
#undef HAVE_LONG_DOUBLE

Expand Down Expand Up @@ -1374,6 +1377,9 @@
/* Define to 1 if you have the <utime.h> header file. */
#undef HAVE_UTIME_H

/* Define to 1 if you have the <utmp.h> header file. */
#undef HAVE_UTMP_H

/* Define to 1 if you have the `uuid_create' function. */
#undef HAVE_UUID_CREATE

Expand Down