Skip to content

bpo-30987 - Support for ISO-TP protocol in SocketCAN #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tiran merged 13 commits into from
Aug 28, 2017
Merged

bpo-30987 - Support for ISO-TP protocol in SocketCAN #2956

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
4d609c0
Added support for CAN_ISOTP protocol
pylessard Jul 26, 2017
ccd65b8
Added unit tests for CAN ISOTP
pylessard Jul 31, 2017
0017156
Updated documentation for ISO-TP protocol
pylessard Jul 31, 2017
85a1545
Removed trailing whitespace in documentation
pylessard Jul 31, 2017
32399d4
Added blurb NEWS.d file
pylessard Jul 31, 2017
fc058f8
updated Misc/ACKS
pylessard Jul 31, 2017
2aa760d
Fixed broken unit test that was using isotp const outside of skippabl…
pylessard Jul 31, 2017
fba09e6
Removed dependecy over third party project
pylessard Aug 3, 2017
17c58d7
Added implementation for getsockname + unit tests
pylessard Aug 3, 2017
7da8fed
Missing newline at end of ACKS file
pylessard Aug 3, 2017
1365fca
Accidentally inserted a type in ACKS file
pylessard Aug 4, 2017
280141c
Followed tiran changes review #1 recommendations
pylessard Aug 26, 2017
e2cc6f3
Added spaces after comma
pylessard Aug 27, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Followed tiran changes review #1 recommendations
  • Loading branch information
@pylessard
pylessard committed Aug 26, 2017
commit 280141c99b81411cd000bb61391a9c39935901c6
6 changes: 3 additions & 3 deletions Lib/test/test_socket.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1747,13 +1747,13 @@ def testCreateISOTPSocket(self):
def testTooLongInterfaceName(self):
# most systems limit IFNAMSIZ to 16, take 1024 to be sure
with socket.socket(socket.PF_CAN, socket.SOCK_DGRAM, socket.CAN_ISOTP) as s:
self.assertRaisesRegex(OSError, 'interface name too long',
s.bind, ('x' * 1024,1,2))
with self.assertRaisesRegex(OSError, 'interface name too long'):
s.bind(('x' * 1024,1,2))

def testBind(self):
try:
with socket.socket(socket.PF_CAN, socket.SOCK_DGRAM, socket.CAN_ISOTP) as s:
addr = (self.interface,0x123,0x456)
addr = self.interface,0x123,0x456
s.bind(addr)
self.assertEqual(s.getsockname(), addr)
except OSError as e:
Expand Down
7 changes: 4 additions & 3 deletions Modules/socketmodule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1882,7 +1882,7 @@ getsockaddrarg(PySocketSockObject *s, PyObject *args,
}
#endif

#if defined(AF_CAN)
#ifdef AF_CAN

#if defined(CAN_RAW) && defined(CAN_BCM)
case AF_CAN:
Expand Down Expand Up @@ -1929,7 +1929,7 @@ getsockaddrarg(PySocketSockObject *s, PyObject *args,
}
#endif

#if defined(CAN_ISOTP)
#ifdef CAN_ISOTP
case CAN_ISOTP:
{
struct sockaddr_can *addr;
Expand Down Expand Up @@ -7055,9 +7055,10 @@ PyInit__socket(void)
PyModule_AddIntMacro(m, CAN_SFF_MASK);
PyModule_AddIntMacro(m, CAN_EFF_MASK);
PyModule_AddIntMacro(m, CAN_ERR_MASK);

#ifdef CAN_ISOTP
PyModule_AddIntMacro(m, CAN_ISOTP);
Copy link
Copy Markdown
Member

@tiran tiran Aug 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs a #ifdef CAN_ISOTP.

#endif
#endif
#ifdef HAVE_LINUX_CAN_RAW_H
PyModule_AddIntMacro(m, CAN_RAW_FILTER);
PyModule_AddIntMacro(m, CAN_RAW_ERR_FILTER);
Expand Down