Skip to content

bpo-45636: BINARY_OP (third time's the charm) #29482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brandtbucher merged 18 commits into from
Nov 11, 2021
Merged

bpo-45636: BINARY_OP (third time's the charm) #29482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
4b7125f
Merge BINARY_*/INPLACE_* into BINARY_OP/INPLACE_OP
brandtbucher Oct 27, 2021
3a87083
Clean things up a bit
brandtbucher Oct 27, 2021
a2df29a
Improve the new _PyNumber_*Op implementations
brandtbucher Oct 27, 2021
1b8934e
Add docs
brandtbucher Oct 27, 2021
3137973
blurb add
brandtbucher Oct 27, 2021
9905549
Fix API leak
brandtbucher Oct 27, 2021
f697036
Clean up the nb_info struct
brandtbucher Oct 28, 2021
33f6e7c
Clean up some comments
brandtbucher Oct 28, 2021
f9e388b
Truly unify all binary ops
brandtbucher Nov 5, 2021
f5b1923
Fix BINARY_OP stats
brandtbucher Nov 6, 2021
2a8072c
Don't defer operators that can't be specialized
brandtbucher Nov 6, 2021
6c6b78f
Remove some old changes
brandtbucher Nov 8, 2021
51c4b5f
Clarify behavior for non-specializing operators
brandtbucher Nov 8, 2021
f0d2056
Clean up dis.py a bit
brandtbucher Nov 8, 2021
45e8502
Remove trailing whitespace
brandtbucher Nov 9, 2021
8d23dad
Apply feedback from code review
brandtbucher Nov 10, 2021
490b8da
Merge branch 'binary-op-unified' of github.com:brandtbucher/cpython i…
brandtbucher Nov 10, 2021
bea2cff
Fix a refleak during error handling
brandtbucher Nov 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Clean up some comments
  • Loading branch information
@brandtbucher
brandtbucher committed Oct 28, 2021
commit 33f6e7c50a48b04810ed5bd57345652041dc102d
4 changes: 4 additions & 0 deletions Python/ceval.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2004,6 +2004,10 @@ _PyEval_EvalFrameDefault(PyThreadState *tstate, InterpreterFrame *frame, int thr
PyObject *divisor = POP();
PyObject *dividend = TOP();
PyObject *res;
// NOTE: This optimization keeps us from rolling modulation into
// BINARY_OP/INPLACE_OP. Once we start specializing those, we can
// get rid of BINARY_MODULO/INPLACE_MODULO and implement this trick
// as a specialized variant.
if (PyUnicode_CheckExact(dividend) && (
!PyUnicode_Check(divisor) || PyUnicode_CheckExact(divisor))) {
// fast path; string formatting, but not if the RHS is a str subclass
Expand Down
2 changes: 1 addition & 1 deletion Python/compile.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3708,7 +3708,7 @@ addop_binary(struct compiler *c, operator_ty binop, bool inplace)
ADDOP(c, inplace ? INPLACE_MODULO : BINARY_MODULO);
return 1;
case Pow:
// Exponentiation is techncally ternary:
// Exponentiation is technically ternary:
ADDOP(c, inplace ? INPLACE_POWER : BINARY_POWER);
return 1;
case LShift:
Expand Down