-
-
Notifications
You must be signed in to change notification settings - Fork 34.5k
[doc] bpo-45680: Disambiguate __getitem__ and __class_getitem__ in the data model.
#29389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+147
−18
Merged
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
020d168
[doc] bpo-45680: Disambiguate ``__getitem__`` and ``__class_getitem__…
AlexWaygood fe66943
Update 2021-11-03-14-30-55.bpo-45680.UBpWzY.rst
AlexWaygood 32d7751
Delete news entry
AlexWaygood efa0731
Address review
AlexWaygood 7ae4fac
Improve links to ``typing`` docs
AlexWaygood 8bc6b7c
Add link to glossary definition
AlexWaygood b01b0c9
Address second review
AlexWaygood ca568d5
Revise changes to ``__getitem__``
AlexWaygood c1955d7
Improve code snippet
AlexWaygood ace22fd
Remove trailing whitespace
AlexWaygood f8ea20a
Fix CI failures
AlexWaygood File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next
Next commit
[doc] bpo-45680: Disambiguate
__getitem__ and ``__class_getitem__…
…`` in the data model. The documentation explaining Python's data model does not adequately explain the differences between ``__getitem__`` and ``__class_getitem__``, nor does it explain when each is called. There is an attempt at explaining ``__class_getitem__`` in the documentation for ``GenericAlias`` objects, but this does not give sufficient clarity into how the method works. Moreover, it is the wrong place for that information to be found; the explanation of ``__class_getitem__`` should be in the documentation explaining the data model. This PR has been split off from #29335.
- Loading branch information
commit 020d1681ec4dd43b73d228f401015011a7c4a0cc
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
Misc/NEWS.d/next/Documentation/2021-11-03-14-30-55.bpo-45680.UBpWzY.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| Disambiguate the differences between ``__getitem__`` and __class_getitem__`` | ||
| in the documentation for the data model. Patch by Alex Waygood. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.