Skip to content

bpo-39452: [doc] Change "must" to "can", on relative import style in __main__ modules#29379

Merged
ambv merged 1 commit into
python:mainfrom
andresdelfino:relative_imports
Nov 6, 2021
Merged

bpo-39452: [doc] Change "must" to "can", on relative import style in __main__ modules#29379
ambv merged 1 commit into
python:mainfrom
andresdelfino:relative_imports

Conversation

@andresdelfino
Copy link
Copy Markdown
Contributor

@andresdelfino andresdelfino commented Nov 2, 2021

The referenced link (https://docs.python.org/3.11/tutorial/modules.html#intra-package-references) says nothing about a requirement on the relative import style.

https://bugs.python.org/issue39452

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Nov 2, 2021
@ambv ambv removed the skip issue label Nov 6, 2021
@ambv ambv changed the title [doc] Change "must" to "can", on relative import style in __main__ modules bpo-39452: [doc] Change "must" to "can", on relative import style in __main__ modules Nov 6, 2021
@ambv ambv merged commit 57457a1 into python:main Nov 6, 2021
@miss-islington
Copy link
Copy Markdown
Contributor

Thanks @andresdelfino for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Nov 6, 2021
…__main__` (pythonGH-29379)

(cherry picked from commit 57457a1)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
@miss-islington
Copy link
Copy Markdown
Contributor

Sorry, @andresdelfino and @ambv, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 57457a1e5caf714034a75fe4f382b8b669ce6ed8 3.9

@bedevere-bot
Copy link
Copy Markdown

GH-29449 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Nov 6, 2021
@ambv
Copy link
Copy Markdown
Contributor

ambv commented Nov 6, 2021

Yeah, this won't be backported to 3.9 as the document there is much different.

@ambv
Copy link
Copy Markdown
Contributor

ambv commented Nov 6, 2021

Thanks, Andre!

ambv pushed a commit that referenced this pull request Nov 6, 2021
…__main__` (GH-29379) (GH-29449)

(cherry picked from commit 57457a1)

Co-authored-by: Andre Delfino <adelfino@gmail.com>
remykarem pushed a commit to remykarem/cpython that referenced this pull request Dec 7, 2021
remykarem pushed a commit to remykarem/cpython that referenced this pull request Jan 30, 2022
@andresdelfino andresdelfino deleted the relative_imports branch October 5, 2024 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation in the Doc dir skip news

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants