Skip to content

bpo-45595: Make extensions depend on header files#29198

Merged
tiran merged 1 commit into
python:mainfrom
tiran:bpo-45595-header-deps
Oct 25, 2021
Merged

bpo-45595: Make extensions depend on header files#29198
tiran merged 1 commit into
python:mainfrom
tiran:bpo-45595-header-deps

Conversation

@tiran
Copy link
Copy Markdown
Member

@tiran tiran commented Oct 24, 2021 •
edited by bedevere-bot
Loading

setup.py and makesetup now track build dependencies on all Python
header files and module specific header files.

Signed-off-by: Christian Heimes christian@python.org

https://bugs.python.org/issue45595

@tiran
bpo-45595: Make extensions depend on header files
22a7c11 
``setup.py`` and ``makesetup`` now track build dependencies on all Python
header files and module specific header files.

Signed-off-by: Christian Heimes <christian@python.org>
@tiran
Copy link
Copy Markdown
Member Author

tiran commented Oct 24, 2021

makesetup now generates

Modules/_sre.o: $(srcdir)/Modules/_sre.c $(MODULE__SRE_DEPS) $(PYTHON_HEADERS); $(CC) $(PY_BUILTIN_MODULE_CFLAGS)  -c $< -o $@
Modules/_sre$(EXT_SUFFIX):  Modules/_sre.o; $(BLDSHARED)  Modules/_sre.o   -o $@

@tiran tiran merged commit 81669d1 into python:main Oct 25, 2021
@bedevere-bot
Copy link
Copy Markdown

bedevere-bot commented Oct 25, 2021 •
edited
Loading

⚠️⚠️⚠️ Buildbot failure ⚠️⚠️⚠️

Hi! The buildbot AMD64 FreeBSD Non-Debug 3.x has failed when building commit 81669d1.

What do you need to do:

  1. Don't panic.
  2. Check the buildbot page in the devguide if you don't know what the buildbots are or how they work.
  3. Go to the page of the buildbot that failed (https://buildbot.python.org/all/#builders/172/builds/1007) and take a look at the build logs.
  4. Check if the failure is related to this commit (81669d1) or if it is a false positive.
  5. If the failure is related to this commit, please, reflect that on the issue and make a new Pull Request with a fix.

You can take a look at the buildbot page here:

https://buildbot.python.org/all/#builders/172/builds/1007

Summary of the results of the build (if available):

Click to see traceback logs 
remote: Enumerating objects: 25, done.        
remote: Counting objects:   4% (1/25)        
remote: Counting objects:   8% (2/25)        
remote: Counting objects:  12% (3/25)        
remote: Counting objects:  16% (4/25)        
remote: Counting objects:  20% (5/25)        
remote: Counting objects:  24% (6/25)        
remote: Counting objects:  28% (7/25)        
remote: Counting objects:  32% (8/25)        
remote: Counting objects:  36% (9/25)        
remote: Counting objects:  40% (10/25)        
remote: Counting objects:  44% (11/25)        
remote: Counting objects:  48% (12/25)        
remote: Counting objects:  52% (13/25)        
remote: Counting objects:  56% (14/25)        
remote: Counting objects:  60% (15/25)        
remote: Counting objects:  64% (16/25)        
remote: Counting objects:  68% (17/25)        
remote: Counting objects:  72% (18/25)        
remote: Counting objects:  76% (19/25)        
remote: Counting objects:  80% (20/25)        
remote: Counting objects:  84% (21/25)        
remote: Counting objects:  88% (22/25)        
remote: Counting objects:  92% (23/25)        
remote: Counting objects:  96% (24/25)        
remote: Counting objects: 100% (25/25)        
remote: Counting objects: 100% (25/25), done.        
remote: Compressing objects:   7% (1/14)        
remote: Compressing objects:  14% (2/14)        
remote: Compressing objects:  21% (3/14)        
remote: Compressing objects:  28% (4/14)        
remote: Compressing objects:  35% (5/14)        
remote: Compressing objects:  42% (6/14)        
remote: Compressing objects:  50% (7/14)        
remote: Compressing objects:  57% (8/14)        
remote: Compressing objects:  64% (9/14)        
remote: Compressing objects:  71% (10/14)        
remote: Compressing objects:  78% (11/14)        
remote: Compressing objects:  85% (12/14)        
remote: Compressing objects:  92% (13/14)        
remote: Compressing objects: 100% (14/14)        
remote: Compressing objects: 100% (14/14), done.        
remote: Total 15 (delta 12), reused 2 (delta 1), pack-reused 0        
From https://github.com/python/cpython
 * branch                  main       -> FETCH_HEAD
Note: switching to '81669d1b7bd668d1bd0fab92836e8b5e7976e362'.

You are in 'detached HEAD' state. You can look around, make experimental
changes and commit them, and you can discard any commits you make in this
state without impacting any branches by switching back to a branch.

If you want to create a new branch to retain commits you create, you may
do so (now or later) by using -c with the switch command. Example:

  git switch -c <new-branch-name>

Or undo this operation with:

  git switch -

Turn off this advice by setting config variable advice.detachedHead to false

HEAD is now at 81669d1b7b [bpo-45595](https://bugs.python.org/issue45595): Make extensions depend on header files (GH-29198)
Switched to and reset branch 'main'

1 error

find: build: No such file or directory
find: build: No such file or directory
find: build: No such file or directory
find: build: No such file or directory

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tiran @bedevere-bot @the-knights-who-say-ni