Skip to content

bpo-44019: Add test_all_exported_names for operator module #29124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
corona10 merged 2 commits into from
Oct 21, 2021
Merged

bpo-44019: Add test_all_exported_names for operator module #29124

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
214225a
bpo-44019: Add test_all_exported_names for operator module
corona10 Oct 21, 2021
fa1c3d6
bpo-44019 Address Victor's code review
corona10 Oct 21, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
bpo-44019 Address Victor's code review
  • Loading branch information
@corona10
corona10 committed Oct 21, 2021
commit fa1c3d653ef4375652a94f6f138eb6b9b8008a67
10 changes: 5 additions & 5 deletions Lib/test/test_operator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,16 +45,16 @@ def __iter__(self):


class OperatorTestCase:
def test_all_exported_names(self):
def test___all__(self):
operator = self.module
actual_all = set(operator.__all__)
computed_all = set()
for k in vars(operator):
if k.startswith('__'):
for name in vars(operator):
if name.startswith('__'):
continue
value = getattr(operator, k)
value = getattr(operator, name)
if value.__module__ in ('operator', '_operator'):
computed_all.add(k)
computed_all.add(name)
self.assertSetEqual(computed_all, actual_all)

def test_lt(self):
Expand Down